424648 - 'Sort by name' produces unexpected behavior on tag containers

Status: RESOLVED INVALID

(Firefox :: Bookmarks & History, defect, P2)

Description

[Damian Shaw [Quan]]

Make sure you have tags and follow these instructions, do NOT go to the places library, it seems to work o.k there

1. Go to bookmark toolbar
2. Click on Smart Bookmarks
3. Click Recent Tags
4. Right click on a tag category
5. Click sort by name
6. A tag disappears 
7. Other things seem to happen, like sometimes it uses the page title to display the name, other times it doesn't

Not sure this can be fixed till bug 419731 is though

Comment 1

[Mike Beltzner [:beltzner, not reading bugmail]]

Mano: pretty sure that this is a dupe, and that you're already looking at this.

Comment 2

[Damian Shaw [Quan]]

Well it's very similar to bug 420003 but I was told not to reopen that bug.

Comment 3

[Ondrej Brablc]

(In reply to comment #2)
> Well it's very similar to bug 420003 but I was told not to reopen that bug.
> 

I have never seen this before (but I was working on "Sort by Name") and I can reproduce it now. So I may be the right one to fix it.

Comment 4

[Marco Bonardo [:mak]]

if bug 419731 lands tag container contents will be sorted by name by default, and being a query the Sort By Name option will not be there

Comment 5

[Damian Shaw [Quan]]

Ignore step 7 from comment #0 this is actually bug 424669

Comment 6

[Marco Bonardo [:mak]]

actually we can't sort tag containers content by design due to the need of having fast dupe filtering of contents (see bug 419731).
we should change the underlying impl to move tags to a separate table (this should help solving duplication perf)

You can temporary sort tag contents in the Library, but no permanent sorting is provided.

So, this should not be a blocker anymore.

Comment 7

[Mike Connor [:mconnor]]

Agreed with Marco.

Comment 8

[Damian Shaw [Quan]]

Connor: This has actually been fixed as far as I can see.

You now no longer get an unexpected behavior. Was fixed by bug 419731.

Comment 9

[Marco Bonardo [:mak]]

well, i'm not sure this is fixed since removing a functionality is not a fix for sure, better invalid probably and a new bug open to restore sort by name functionality on tag containers in future

Comment 10

[Marco Bonardo [:mak]]

filled bug 429686

Comment 11

[Gervase Markham [:gerv]]

Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h".

In Thunderbird 3.0b, you do that as follows:
Tools | Message Filters
Make sure the correct account is selected. Click "New"
Conditions: Body   contains   places-to-b-and-h
Change the action to "Delete Message".
Select "Manually Run" from the dropdown at the top.
Click OK.

Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter.

Gerv