424650 - Wrong nsAutoPtr usage break Mingw build

Status: RESOLVED FIXED

(Core :: Graphics, defect)

Description

[Bo Yang]

There is one line of code break Mingw build of Firefox trunk. And it is :

nsAutoPtr<UniscribeItem> item = us.GetItem(i, this);

The mingw gcc complain that it request a conversion between UniscribeItem* to nsAutoPtr<UniscribeItem>. And after I have searh some code of Mozilla, I can't find any similar usage with nsAutoPtr. Maybe this is a Microsoft C compiler only usage? 

Anyway, I decide to report this as a bug and hope I can get more advice!
Thanks!

Comment 1

[Bo Yang]

Attachment: A potential patch

Change 

nsAutoPtr<UniscribeItem> item = us.GetItem(i, this);

to

nsAutoPtr<UniscribeItem> item(us.GetItem(i, this));

to make the compiler not complain.

Comment 3

[Martijn Wargers (dead)]

Comment on attachment 311240 [details] [diff] [review]
A potential patch

Thanks for the patch!
You need to ask review, if you want the patch to get checked in, eventually.

Comment 4

[Reed Loden [:reed]]

Comment on attachment 311240 [details] [diff] [review]
A potential patch

One-line build fix for mingw.

Comment 5

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 311240 [details] [diff] [review]
A potential patch

a1.9b5=beltzner

Comment 6

[Reed Loden [:reed]]

Checking in gfx/thebes/src/gfxWindowsFonts.cpp;
/cvsroot/mozilla/gfx/thebes/src/gfxWindowsFonts.cpp,v  <--  gfxWindowsFonts.cpp
new revision: 1.183; previous revision: 1.182
done