Closed Bug 424750 Opened 16 years ago Closed 16 years ago

dtrace no longer compiles as JSFunction.u.n.clasp is no longer available.

Categories

(Core :: JavaScript Engine, defect)

Product:
Core
Component:
JavaScript Engine
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED

People

(Reporter: igor, Assigned: alfred.peng)

References

Details

Attachments

(1 file)

patch v1
976 bytes, patch
igor
: review+
Details | Diff | Splinter Review 
Bug 424376 comment 14 provides the details.
Blocks: 424376
No longer depends on: 424376
(In reply to bug 424376 comment #14)
> igor, any suggestion on the patch?

The patch is fine.
Attached patch patch v1 — — Splinter Review 
It's better to post the patch here. I'll obsolete the old one.
Attachment #311341 - Flags: review?(igor)
Comment on attachment 311341 [details] [diff] [review]
patch v1

As igor's comment 1 is fine, I'd like to ask for b5 approval for this followup fix.
Attachment #311341 - Flags: approval1.9b5?
Attachment #311341 - Flags: review?(igor) → review+
(In reply to comment #3)
> (From update of attachment 311341 [details] [diff] [review])
> As igor's comment 1 is fine, I'd like to ask for b5 approval for this followup
> fix.

dtrace code is not a part of the default browser build. As such no approval is necessary.
Assignee: general → alfred.peng
Keywords: checkin-needed
Comment on attachment 311341 [details] [diff] [review]
patch v1

Cancel the request for b5 approval per igor's comment above.
Attachment #311341 - Flags: approval1.9b5?
I checked in the patch from the comment 2 to the trunk:

Checking in jsdtracef.c;
/cvsroot/mozilla/js/src/jsdtracef.c,v  <--  jsdtracef.c
new revision: 3.8; previous revision: 3.7
done
Status: NEW → RESOLVED
Closed: 16 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Flags: in-testsuite-
Flags: in-litmus-
Blocks: 425744
No longer blocks: 425744
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: