4248 - [INLINE-H][WHITESPACE]{ll} Trailing spaces on inline elements wrapping at boundary poorly treated

Status: RESOLVED WORKSFORME

(Core :: Layout: Block and Inline, defect, P4)

Description

[Hixie (not reading bugmail)]

See test three on the test page:
  http://www.bath.ac.uk/%7Epy8ieh/internet/eviltests/emptyinline.html

PROBLEM: An inline element with a space trailing at the end which wraps at the
block box boundary does not have a closing border.

SOLUTION: The 'correct' behaviour is not defined by any spec AFAIK. I suggest
emulating the behaviour of Opera 3.51, a trial copy of which is downloadable
from
   http://www.operasoftware.com/

This basically involves collapsing the space into the newline, realising this
has happened, and strategically moving the newline outside the inline element,
so that the inline element simply loses its space and is placed at the end of
the line as if it had never had the space.

David Baron has kindly donated a screen shot of the current behaviour:
   http://www.fas.harvard.edu/~dbaron/tests/nglayout/ieh_inl.gif

As can be seen, the current behaviour is suboptimal at best.

Comment 1

[Hixie (not reading bugmail)]

Adding David to cc list. I meant to do that yesterday, but forgot.

Comment 2

[Hixie (not reading bugmail)]

*** Bug 1519 has been marked as a duplicate of this bug. ***

Comment 3

[Hixie (not reading bugmail)]

Bug 1519 dealt with this issue in the case of underlining and trailing spaces.

The URI was: http://www.w3.org/Style/CSS/Test/adhoc/nov23.html
In Section (7), the underlined space character after "the text." should have
been collapsed, as should the the underlined space characters at the end of each
line in section (6).

Comment 4

[leger]

Updating to default Layout Assignee...kipp no longer with us :-(

Comment 5

[troy]

Why are you re-reassing layout bugs? Do NOT touch layout bugs.

The bugs are assigned to Kipp so they can stay neatly organized until we have a
new owner for the block/inline code.

Comment 6

[buster]

mass moving all Kipp's pre-beta bugs to M15.  Nisheeth and I will
prioritize these and selectively move high-priority bugs into M13 and M14.

Comment 7

[buster]

mine! mine mine mine!  all mine!  whoo-hoo!

Comment 8

[rickg]

moving all buster m15 bugs to m16.

Comment 9

[buster]

low priority bug.  I agree what we do isn't the best.

Comment 10

[buster]

redistributing bugs across future milestones, sorry for the spam

Comment 11

[buster]

This bug is marked "future" because it is not critical for RTM (Release To 
Manufacturing). If anyone believes it is critical, please explain why
in this bug. 

Comment 12

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Attachment: screenshot of current behavior

Comment 13

[Hixie (not reading bugmail)]

Has this fixed itself? I cannot reproduce the bad behaviour with Win2K 
commerical build 6.0.17.200072811.

Comment 14

[Hixie (not reading bugmail)]

Taking QA per managerial policy.

Comment 15

[Hixie (not reading bugmail)]

Actually, now we almost do it right, except that we overlap the border and the
last letter slightly.

Comment 16

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Ian attached some interesting testcases to bug 86746 that are really more
related to this bug (or something related to this):

------- Additional Comments From Ian 'Hixie' Hickson 2001-06-19 18:22 -------

The problem is actually that there is a space at the start and end of the 
float's contents, which is rather strange. See the following tests:
   http://www.hixie.ch/tests/adhoc/css/box/float/011.xml
http://www.hixie.ch/tests/adhoc/css/box/float/012.xml
http://www.hixie.ch/tests/adhoc/css/box/float/013.xml

Note. You will need the Ahem font for these tests. You may obtain a copy here:
   http://www.hixie.ch/resources/fonts/

Comment 17

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

*** Bug 68115 has been marked as a duplicate of this bug. ***

Comment 18

[rbs]

This bug has been fixed. I am not getting the screenshot with a current build.

Comment 19

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Not all the issues here have been fixed, and I've marked some recent bugs as
duplicates of it since they haven't been fixed.  If you're going to mark this
one fixed, could you at least figure out what the others should be dups of?

Reopening.

Comment 20

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

(I think the original symptom is gone but the underlying problem still exists.)

Comment 21

[rbs]

This is perhaps a manifestation of the following observation reported in the code
comments -- I also encountered this while working on the font stuff. (I haven't
done any testing w.r.t. to this bug so I am not really sure.) 
http://bonsai.mozilla.org/cvsview2.cgi?diff_mode=context&whitespace_mode=show&subdir=mozilla/layout/html/base/src&command=DIFF_FRAMESET&file=nsLineLayout.cpp&rev1=3.101.2.2&rev2=3.101.2.3&root=/cvsroot

Comment 22

[Kevin McCluskey (gone)]

Build reassigning Buster's bugs to Marc.

Comment 23

[rubydoo123]

reduced priority to P4

Comment 24

[Greg K.]

Apparently WorksForMe using FizzillaCFM/2002070913 (testing for possible
platform=all). With the browser window sized so that the "STRONG" inline box is
at the end of a line, the line below doesn't appear to be at all affected by
borders or weird line height; certainly nothing like the screenshot. Am I
looking at this right? Is this still a problem, or a genuine PC-only problem?

Comment 25

[Hixie (not reading bugmail)]

this does seem to be worksforme now, yeah. cool. wonder what happened.

Comment 26

[Christopher Hoess (gone)]

Removing css1 since there seems to be no governing spec.

Comment 27

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

block/inline

Comment 28

[Hixie (not reading bugmail)]

None of the testcases attached to or mentioned on this bug fail any more, they
all work very nicely. WORKSFORME?

Comment 29

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

See comment 19 - comment 20.  If you want to resolve this one, make sure another
one is open to cover the other issues, if they still exist.

Comment 30

[Hixie (not reading bugmail)]

I reopened bug 68115, bug 1519 is fixed now. Marking WORKSFORME.