Closed
Bug 42501
Opened 24 years ago
Closed 20 years ago
fail to release HTML element in HTMLContentSink::ProcessScriptTag
Categories
(Core :: DOM: HTML Parser, defect, P3)
Core
DOM: HTML Parser
Tracking
()
RESOLVED
WORKSFORME
Future
People
(Reporter: waterson, Assigned: jst)
References
()
Details
(Keywords: memory-leak, Whiteboard: [nsbeta3-])
See patrick's leak root test. This is a real obvious one, I think. At http://lxr.mozilla.org/mozilla/source/layout/html/document/src/nsHTMLContentSink.cpp#4560 you create an HMTL element with a bare pointer (luddite!), and then drop it on the floor about ten lines later. Use a nsCOMPtr!
Reporter | ||
Comment 1•24 years ago
|
||
Well, never mind. I was wrong. This code doesn't leak here (it still leaks!) but it's not in the method I thought it was. And you're still a luddite ;-).
Comment 2•24 years ago
|
||
This code was written before nsCOMPtrs were even a twinkle in anyone's eye, sonny boy. MLK, so I'll put it high on the priority list.
Status: NEW → ASSIGNED
Updated•24 years ago
|
Whiteboard: [nsbeta3+]
Comment 3•24 years ago
|
||
Re-assigning bug to jst as per our decision in yesterday's bug triage meeting.
Status: ASSIGNED → NEW
Assignee | ||
Comment 6•24 years ago
|
||
This bug has been marked "future" because the original netscape engineer working on this is over-burdened. If you feel this is an error, that you or another known resource will be working on this bug,or if it blocks your work in some way -- please attach your concern to the bug for reconsideration.
Status: NEW → ASSIGNED
Target Milestone: --- → Future
Comment 8•21 years ago
|
||
Is this still an issue? It's not clear what this leak root test did, and I've not seen script elements leaking in leak logs....
Comment 9•20 years ago
|
||
Going out on a limb an marking worksforme. As existing this bug isn't really useful...
Status: ASSIGNED → RESOLVED
Closed: 20 years ago
Resolution: --- → WORKSFORME
You need to log in
before you can comment on or make changes to this bug.
Description
•