425164 - Change duplicated accesskeys in Disk Space panels

Status: VERIFIED FIXED

(SeaMonkey :: MailNews: Account Configuration, defect)

Description

[Giacomo Magnini]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; it; rv:1.9b5pre) Gecko/2008032504 Minefield/3.0b5pre
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; it; rv:1.9b5pre) Gecko/2008032504 Minefield/3.0b5pre

The (Offline &) Disk Space panels in the account manager have many duplicated accesskeys. We should change some to solve the issue.

Reproducible: Always

Steps to Reproduce:
1.
2.
3.

Comment 1

[Giacomo Magnini]

Attachment: This should be it.

Tested with POP, IMAP, News, Movemail and Local Folders accounts.

Comment 2

[Robert Kaiser]

Comment on attachment 311772 [details] [diff] [review]
This should be it.

>Index: suite/locales/en-US/chrome/mailnews/pref/am-offline.dtd
>===================================================================
> <!ENTITY nntpNotDownloadRead.label "Read messages">
>-<!ENTITY nntpNotDownloadRead.accesskey "R">
>+<!ENTITY nntpNotDownloadRead.accesskey "d">
> <!ENTITY nntpDownloadMsg.label "Messages more than">
> <!ENTITY nntpDownloadMsg.accesskey "e">
> <!ENTITY retentionCleanup.label "To recover disk space, old messages can be permanently deleted">
> <!ENTITY retentionKeepMsg.label "Delete messages more than">
>-<!ENTITY retentionKeepMsg.accesskey "m">
>+<!ENTITY retentionKeepMsg.accesskey "t">

Is there some possibility to change it to use "D" here? First-letter matches are preferred if possible, and "t" is suboptimal for being a bit narrow ("t" and "f" are still better than "l", "I" or "j" though).

Please also look if the matching Thunderbird file has the same problems.

Comment 3

[Giacomo Magnini]

Can't use D, as I need it for "Read messages" in the same panel for Offline/Local Folders: otherwise I was left with no free accesskey for such a string.

Comment 4

[Robert Kaiser]

Comment on attachment 311772 [details] [diff] [review]
This should be it.

bummer. OK, I don't really like it but see no better solution. r= me.

Comment 5

[Giacomo Magnini]

Attachment: Added TB version, too.

Carrying over r+

Comment 6

[Phil Ringnalda (:philor)]

Comment on attachment 312714 [details] [diff] [review]
Added TB version, too.

r=me, thanks

Comment 7

[Reed Loden [:reed]]

Checking in suite/locales/en-US/chrome/mailnews/pref/am-offline.dtd;
/cvsroot/mozilla/suite/locales/en-US/chrome/mailnews/pref/am-offline.dtd,v  <--  am-offline.dtd
new revision: 1.12; previous revision: 1.11
done
Checking in mail/locales/en-US/chrome/messenger/am-offline.dtd;
/cvsroot/mozilla/mail/locales/en-US/chrome/messenger/am-offline.dtd,v  <--  am-offline.dtd
new revision: 1.6; previous revision: 1.5
done

Comment 8

[Giacomo Magnini]

Verified with build id: 2008040501