425375 - Location bar loses focus when last tab is closed (now by clicking close button)

Status: VERIFIED FIXED

(Firefox :: Tabbed Browser, defect)

Description

[Marat Tanalin]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9b5pre) Gecko/2008032605 Minefield/3.0b5pre
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9b5pre) Gecko/2008032605 Minefield/3.0b5pre

First of all, nearly identical bug report (bug 356581) is already on the bug tracker. But, though that bug (see the title) wasn't tied strongly to particular steps (closing CTRL+W or another method, just abstract *closing tab*), Simon Bünzli said (https://bugzilla.mozilla.org/show_bug.cgi?id=356581#c15) that the new bug should be reported, so here it is (and naturally it is mainly copy of mentioned existing bug report, only closing method and Firefox version are changed).

When we try to close last tab when the option "Always show the tab bar" in dialogue [Tools] -> [Options] -> [Tabs] is turned on, the location bar loses focus.

It make big sense at this situation to focus location bar -- as it takes place both on Firefox start and when we create new tab with CTRL+T. It is useful and it really make sense.

Reproducible: Always

Steps to Reproduce:
1. Start Firefox with one tab open. One (empty) tab is open and the location bar has focus.
2. Close the tab by clicking close button on the tab. One tab is as before open and empty, but location bar isn't focused anymore.
3. Click CTRL+W (that only has been fixed), and location bar has focus again. (Just another closing method, and the problem disappears. Non sense.)
Actual Results:  
The location bar loses focus though visual and functional statuses of browser and of the tab are the same as right after Firefox start.

Expected Results:  
Location bar should (or is very useful/expected-by-user at least) still have focus when user has tried to close last tab.

This bug affects latest trunk build of Firefox 3 (Gecko/2008032106) as well as all prior Fx3 builds.

Probably it may be easily fixed before final Firefox 3.0 ships. Thanks.

Comment 1

[Marat Tanalin]

Addition: latest Gecko/2008032605 is of course affected by this bug too.

Comment 2

[Dão Gottwald [:dao]]

This should be fixed by bug 455852.

Comment 3

[Marcia Knous [:marcia]]

verified fixed using Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.1b1pre) Gecko/20081003 Minefield/3.1b1pre.

Comment 4

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Stephen, you have added the following Litmus testcase (https://litmus.mozilla.org/show_test.cgi?id=6646) but forgot the step with the hidden pref. The test should be updated. I'll note it.

Comment 5

[Dão Gottwald [:dao]]

Test checked in:
http://hg.mozilla.org/mozilla-central/rev/bd315a993149

Comment 6

[Stephen Donner [:stephend] Not actively reading bugmail]

Dão just covered this via the automated test, so I'm eliminating the redundancy by disabling (but not deleting), https://litmus.mozilla.org/show_test.cgi?id=6646.

in-litmus-