425689 - [lt] Update Wikipedia searchplugin to match title

Status: VERIFIED FIXED

(Mozilla Localizations :: lt / Lithuanian, defect)

Description

[Axel Hecht [:Pike]]

Wikipedia changed their site to say (ab-CD), mind creating a patch to reflect that?

You can find the exact title by going to http://lt-LT.wikipedia.org/, view source, find the rel="search" link and pick its title.

"Wikipedia (LT)" should be "Wikipedia (lt)" according to my latest check.

Comment 1

[Axel Hecht [:Pike]]

make that http://lt.wikipedia.org/

Comment 2

[Rimas Kudelis [use needinfo to ping]]

Hm.. A few questions:

Did I understand this correctly – all you want is to change the name from "Wikipedia (LT)" to "Wikipedia (lt)", and that's it?

Do you want me to fix that also on branch?

Do I need to ask for your approval to land these changes in Trunk here?

Maybe I should copy over the English wikipedia searchplugin, and just alter its ShortName, Description, URL and SearchForm fields? Because Lithuanian Searchplugin lacks suggestion feature.

Comment 3

[Axel Hecht [:Pike]]

Actually, taking the en-US plugin as sample is a good idea, missed that in my auto-filing spree, and in my current post-filing hunt.

I think the Url template for the regular search and for the SearchForm should be http://lt.wikipedia.org/wiki/Specialus:Search, ShortName with lowercase lt.

For the branch, we could land the changes on the branch, too. Not sure if a trunk patch would apply there, but if you create one, please request approval1.8.1.14.

For the trunk, please request review from me on the patch, we're using that for approvals for now, until we have a proper flag that I could actually set, too.

Comment 4

[Rimas Kudelis [use needinfo to ping]]

Attachment: Trunk Patch

Comment 5

[Rimas Kudelis [use needinfo to ping]]

Attachment: Branch Patch

Comment 6

[Axel Hecht [:Pike]]

Comment on attachment 312307 [details] [diff] [review]
Trunk Patch

r=me, please check in with a comment referencing this bug and my review.

Comment 7

[Axel Hecht [:Pike]]

Comment on attachment 312308 [details] [diff] [review]
Branch Patch

r,a=me, please check this in and track landing and testing for the branch with the fixed... and verified1.8.1.14 keywords.

Comment 8

[Rimas Kudelis [use needinfo to ping]]

Update landed on Trunk:
Checking in browser/searchplugins/wikipedia-lt.xml;
/l10n/l10n/lt/browser/searchplugins/wikipedia-lt.xml,v  <--  wikipedia-lt.xml
new revision: 1.3; previous revision: 1.2
done

And on Branch:
Checking in browser/searchplugins/wikipedia-lt.xml;
/l10n/l10n/lt/browser/searchplugins/wikipedia-lt.xml,v  <--  wikipedia-lt.xml
new revision: 1.1.2.2; previous revision: 1.1.2.1
done

Comment 9

[Rimas Kudelis [use needinfo to ping]]

Verifying with the following build:

Mozilla/5.0 (X11; U; Linux i686; lt; rv:1.8.1.14pre) Gecko/20080328 BonEcho/2.0.0.14pre

Comment 10

[Rimas Kudelis [use needinfo to ping]]

Also verifying with the following trunk build:
Mozilla/5.0 (X11; U; Linux i686; lt; rv:1.9pre) Gecko/2008032804 Minefield/3.0pre