426415 - Sisyphus|JavaScript Tests - remove hard coded path dependencies, support mozilla-build on Windows

Status: RESOLVED FIXED

(Testing Graveyard :: Sisyphus, defect)

Description

[Bob Clary [:bc] (inactive)]

Attachment: sisyphus patch

This patch does the following:

reduces the dependency on hard coded paths /work/mozilla/mozilla.com/test.mozilla.com/www and /work/mozilla/builds by requiring the TEST_DIR environment variable be set to point to the Sisyphus directory. This can be achieved for each installation by setting TEST_DIR in the .bash_profile.

updates the Sisyphus build system to use mozilla-build on Windows and includes updates to use the latest Windows SDK 6.1 for Visual Studio 2005 in order to support building with the parental controls api.

updates timed_run.py to take every opportunity to flush stdout and stderr before exiting.

updates the data files to use the TEST_DIR environment variable as well as update paths to builds on the ftp server.

Comment 1

[Bob Clary [:bc] (inactive)]

Attachment: js tests patch

This patch updates the scripts in the JavaScript Engine tests to use the new style TEST_DIR environment variable.

Comment 2

[Rob Campbell [:rc] (:robcee)]

Comment on attachment 312955 [details] [diff] [review]
sisyphus patch

this is monstrous. I'm going to hope that you got it right. :)

Comment 3

[Bob Clary [:bc] (inactive)]

Attachment: sisyphus patch v2

what I am actually checking in. When I installed the Windows SDK locally on XP and Vista from the iso, it was the SDK for Windows 2008 (v6.1), but that won't install on Windows XP via the online Setup.exe. However the Windows SDK update for Vista (v6.0) will install on XP via the online Setup.exe. This second patch simply checks for v6.0 first and uses that patch for the SDK if it exists, otherwise it will use v6.1.

Comment 4

[Bob Clary [:bc] (inactive)]

Checking in bin/build.sh;
/cvsroot/mozilla/testing/sisyphus/bin/build.sh,v  <--  build.sh
new revision: 1.7; previous revision: 1.6
done
Checking in bin/builder.sh;
/cvsroot/mozilla/testing/sisyphus/bin/builder.sh,v  <--  builder.sh
new revision: 1.7; previous revision: 1.6
done
Checking in bin/check-spider.sh;
/cvsroot/mozilla/testing/sisyphus/bin/check-spider.sh,v  <--  check-spider.sh
new revision: 1.5; previous revision: 1.4
done
Checking in bin/checkout.sh;
/cvsroot/mozilla/testing/sisyphus/bin/checkout.sh,v  <--  checkout.sh
new revision: 1.8; previous revision: 1.7
done
Checking in bin/clean.sh;
/cvsroot/mozilla/testing/sisyphus/bin/clean.sh,v  <--  clean.sh
new revision: 1.5; previous revision: 1.4
done
Checking in bin/create-directory.sh;
/cvsroot/mozilla/testing/sisyphus/bin/create-directory.sh,v  <--  create-directory.sh
new revision: 1.5; previous revision: 1.4
done
Checking in bin/create-profile.sh;
/cvsroot/mozilla/testing/sisyphus/bin/create-profile.sh,v  <--  create-profile.sh
new revision: 1.5; previous revision: 1.4
done
Checking in bin/edit-talkback.sh;
/cvsroot/mozilla/testing/sisyphus/bin/edit-talkback.sh,v  <--  edit-talkback.sh
new revision: 1.7; previous revision: 1.6
done
Checking in bin/install-build.sh;
/cvsroot/mozilla/testing/sisyphus/bin/install-build.sh,v  <--  install-build.sh
new revision: 1.7; previous revision: 1.6
done
Checking in bin/install-extensions.sh;
/cvsroot/mozilla/testing/sisyphus/bin/install-extensions.sh,v  <--  install-extensions.sh
new revision: 1.6; previous revision: 1.5
done
Checking in bin/install-plugins.sh;
/cvsroot/mozilla/testing/sisyphus/bin/install-plugins.sh,v  <--  install-plugins.sh
new revision: 1.5; previous revision: 1.4
done
Checking in bin/library.sh;
/cvsroot/mozilla/testing/sisyphus/bin/library.sh,v  <--  library.sh
new revision: 1.10; previous revision: 1.9
done
Checking in bin/set-build-env.sh;
/cvsroot/mozilla/testing/sisyphus/bin/set-build-env.sh,v  <--  set-build-env.sh
new revision: 1.6; previous revision: 1.5
done
Checking in bin/set-msvc6-env.sh;
/cvsroot/mozilla/testing/sisyphus/bin/set-msvc6-env.sh,v  <--  set-msvc6-env.sh
new revision: 1.2; previous revision: 1.1
done
Checking in bin/set-msvc8-env.sh;
/cvsroot/mozilla/testing/sisyphus/bin/set-msvc8-env.sh,v  <--  set-msvc8-env.sh
new revision: 1.3; previous revision: 1.2
done
Checking in bin/smoke-build.sh;
/cvsroot/mozilla/testing/sisyphus/bin/smoke-build.sh,v  <--  smoke-build.sh
new revision: 1.6; previous revision: 1.5
done
Checking in bin/spider.pl;
/cvsroot/mozilla/testing/sisyphus/bin/spider.pl,v  <--  spider.pl
new revision: 1.2; previous revision: 1.1
done
Checking in bin/test-setup.sh;
/cvsroot/mozilla/testing/sisyphus/bin/test-setup.sh,v  <--  test-setup.sh
new revision: 1.8; previous revision: 1.7
done
Checking in bin/tester.sh;
/cvsroot/mozilla/testing/sisyphus/bin/tester.sh,v  <--  tester.sh
new revision: 1.9; previous revision: 1.8
done
Checking in bin/timed_run.py;
/cvsroot/mozilla/testing/sisyphus/bin/timed_run.py,v  <--  timed_run.py
new revision: 1.4; previous revision: 1.3
done
Checking in bin/uninstall-build.sh;
/cvsroot/mozilla/testing/sisyphus/bin/uninstall-build.sh,v  <--  uninstall-build.sh
new revision: 1.5; previous revision: 1.4
done
Checking in data/download-check,firefox-1.5.0-ftp,linux.data;
/cvsroot/mozilla/testing/sisyphus/data/download-check,firefox-1.5.0-ftp,linux.data,v  <--  download-check,firefox-1.5.0-ftp,linux.data
new revision: 1.4; previous revision: 1.3
done
Checking in data/download-check,firefox-1.5.0-ftp,mac.data;
/cvsroot/mozilla/testing/sisyphus/data/download-check,firefox-1.5.0-ftp,mac.data,v  <--  download-check,firefox-1.5.0-ftp,mac.data
new revision: 1.4; previous revision: 1.3
done
Checking in data/download-check,firefox-1.5.0-ftp,win32.data;
/cvsroot/mozilla/testing/sisyphus/data/download-check,firefox-1.5.0-ftp,win32.data,v  <--  download-check,firefox-1.5.0-ftp,win32.data
new revision: 1.4; previous revision: 1.3
done
Checking in data/download-check,firefox-2.0.0-ftp,linux.data;
/cvsroot/mozilla/testing/sisyphus/data/download-check,firefox-2.0.0-ftp,linux.data,v  <--  download-check,firefox-2.0.0-ftp,linux.data
new revision: 1.4; previous revision: 1.3
done
Checking in data/download-check,firefox-2.0.0-ftp,mac.data;
/cvsroot/mozilla/testing/sisyphus/data/download-check,firefox-2.0.0-ftp,mac.data,v  <--  download-check,firefox-2.0.0-ftp,mac.data
new revision: 1.4; previous revision: 1.3
done
Checking in data/download-check,firefox-2.0.0-ftp,win32.data;
/cvsroot/mozilla/testing/sisyphus/data/download-check,firefox-2.0.0-ftp,win32.data,v  <--  download-check,firefox-2.0.0-ftp,win32.data
new revision: 1.4; previous revision: 1.3
done
Checking in data/download-check,firefox-all,linux.data;
/cvsroot/mozilla/testing/sisyphus/data/download-check,firefox-all,linux.data,v  <--  download-check,firefox-all,linux.data
new revision: 1.4; previous revision: 1.3
done
Checking in data/download-check,firefox-all,mac.data;
/cvsroot/mozilla/testing/sisyphus/data/download-check,firefox-all,mac.data,v  <--  download-check,firefox-all,mac.data
new revision: 1.4; previous revision: 1.3
done
Checking in data/download-check,firefox-all,win32.data;
/cvsroot/mozilla/testing/sisyphus/data/download-check,firefox-all,win32.data,v  <--  download-check,firefox-all,win32.data
new revision: 1.4; previous revision: 1.3
done
Checking in data/download-check,firefox-all-older,linux.data;
/cvsroot/mozilla/testing/sisyphus/data/download-check,firefox-all-older,linux.data,v  <--  download-check,firefox-all-older,linux.data
new revision: 1.4; previous revision: 1.3
done
Checking in data/download-check,firefox-all-older,mac.data;
/cvsroot/mozilla/testing/sisyphus/data/download-check,firefox-all-older,mac.data,v  <--  download-check,firefox-all-older,mac.data
new revision: 1.4; previous revision: 1.3
done
Checking in data/download-check,firefox-all-older,win32.data;
/cvsroot/mozilla/testing/sisyphus/data/download-check,firefox-all-older,win32.data,v  <--  download-check,firefox-all-older,win32.data
new revision: 1.4; previous revision: 1.3
done
Checking in data/download-check,thunderbird-1.5.0-ftp,linux.data;
/cvsroot/mozilla/testing/sisyphus/data/download-check,thunderbird-1.5.0-ftp,linux.data,v  <--  download-check,thunderbird-1.5.0-ftp,linux.data
new revision: 1.4; previous revision: 1.3
done
Checking in data/download-check,thunderbird-1.5.0-ftp,mac.data;
/cvsroot/mozilla/testing/sisyphus/data/download-check,thunderbird-1.5.0-ftp,mac.data,v  <--  download-check,thunderbird-1.5.0-ftp,mac.data
new revision: 1.4; previous revision: 1.3
done
Checking in data/download-check,thunderbird-1.5.0-ftp,win32.data;
/cvsroot/mozilla/testing/sisyphus/data/download-check,thunderbird-1.5.0-ftp,win32.data,v  <--  download-check,thunderbird-1.5.0-ftp,win32.data
new revision: 1.4; previous revision: 1.3
done
Checking in data/download-check,thunderbird-2.0.0-ftp,linux.data;
/cvsroot/mozilla/testing/sisyphus/data/download-check,thunderbird-2.0.0-ftp,linux.data,v  <--  download-check,thunderbird-2.0.0-ftp,linux.data
new revision: 1.4; previous revision: 1.3
done
Checking in data/download-check,thunderbird-2.0.0-ftp,mac.data;
/cvsroot/mozilla/testing/sisyphus/data/download-check,thunderbird-2.0.0-ftp,mac.data,v  <--  download-check,thunderbird-2.0.0-ftp,mac.data
new revision: 1.4; previous revision: 1.3
done
Checking in data/download-check,thunderbird-2.0.0-ftp,win32.data;
/cvsroot/mozilla/testing/sisyphus/data/download-check,thunderbird-2.0.0-ftp,win32.data,v  <--  download-check,thunderbird-2.0.0-ftp,win32.data
new revision: 1.4; previous revision: 1.3
done
Checking in data/download-check,thunderbird-all,linux.data;
/cvsroot/mozilla/testing/sisyphus/data/download-check,thunderbird-all,linux.data,v  <--  download-check,thunderbird-all,linux.data
new revision: 1.4; previous revision: 1.3
done
Checking in data/download-check,thunderbird-all,mac.data;
/cvsroot/mozilla/testing/sisyphus/data/download-check,thunderbird-all,mac.data,v  <--  download-check,thunderbird-all,mac.data
new revision: 1.4; previous revision: 1.3
done
Checking in data/download-check,thunderbird-all,win32.data;
/cvsroot/mozilla/testing/sisyphus/data/download-check,thunderbird-all,win32.data,v  <--  download-check,thunderbird-all,win32.data
new revision: 1.4; previous revision: 1.3
done
Checking in data/download-check,thunderbird-all-older,linux.data;
/cvsroot/mozilla/testing/sisyphus/data/download-check,thunderbird-all-older,linux.data,v  <--  download-check,thunderbird-all-older,linux.data
new revision: 1.4; previous revision: 1.3
done
Checking in data/download-check,thunderbird-all-older,mac.data;
/cvsroot/mozilla/testing/sisyphus/data/download-check,thunderbird-all-older,mac.data,v  <--  download-check,thunderbird-all-older,mac.data
new revision: 1.4; previous revision: 1.3
done
Checking in data/download-check,thunderbird-all-older,win32.data;
/cvsroot/mozilla/testing/sisyphus/data/download-check,thunderbird-all-older,win32.data,v  <--  download-check,thunderbird-all-older,win32.data
new revision: 1.4; previous revision: 1.3
done
Checking in data/firefox,1.8.0,debug.data;
/cvsroot/mozilla/testing/sisyphus/data/firefox,1.8.0,debug.data,v  <--  firefox,1.8.0,debug.data
new revision: 1.3; previous revision: 1.2
done
Checking in data/firefox,1.8.0,nightly-linux.data;
/cvsroot/mozilla/testing/sisyphus/data/firefox,1.8.0,nightly-linux.data,v  <--  firefox,1.8.0,nightly-linux.data
new revision: 1.4; previous revision: 1.3
done
Checking in data/firefox,1.8.0,nightly-mac.data;
/cvsroot/mozilla/testing/sisyphus/data/firefox,1.8.0,nightly-mac.data,v  <--  firefox,1.8.0,nightly-mac.data
new revision: 1.4; previous revision: 1.3
done
Checking in data/firefox,1.8.0,nightly-win32.data;
/cvsroot/mozilla/testing/sisyphus/data/firefox,1.8.0,nightly-win32.data,v  <--  firefox,1.8.0,nightly-win32.data
new revision: 1.4; previous revision: 1.3
done
Checking in data/firefox,1.8.0,opt.data;
/cvsroot/mozilla/testing/sisyphus/data/firefox,1.8.0,opt.data,v  <--  firefox,1.8.0,opt.data
new revision: 1.3; previous revision: 1.2
done
Checking in data/firefox,1.8.0-test,debug.data;
/cvsroot/mozilla/testing/sisyphus/data/firefox,1.8.0-test,debug.data,v  <--  firefox,1.8.0-test,debug.data
new revision: 1.3; previous revision: 1.2
done
Checking in data/firefox,1.8.0-test,opt.data;
/cvsroot/mozilla/testing/sisyphus/data/firefox,1.8.0-test,opt.data,v  <--  firefox,1.8.0-test,opt.data
new revision: 1.3; previous revision: 1.2
done
Checking in data/firefox,1.8.1,debug.data;
/cvsroot/mozilla/testing/sisyphus/data/firefox,1.8.1,debug.data,v  <--  firefox,1.8.1,debug.data
new revision: 1.3; previous revision: 1.2
done
Checking in data/firefox,1.8.1,nightly-linux.data;
/cvsroot/mozilla/testing/sisyphus/data/firefox,1.8.1,nightly-linux.data,v  <--  firefox,1.8.1,nightly-linux.data
new revision: 1.4; previous revision: 1.3
done
Checking in data/firefox,1.8.1,nightly-mac.data;
/cvsroot/mozilla/testing/sisyphus/data/firefox,1.8.1,nightly-mac.data,v  <--  firefox,1.8.1,nightly-mac.data
new revision: 1.4; previous revision: 1.3
done
Checking in data/firefox,1.8.1,nightly-win32.data;
/cvsroot/mozilla/testing/sisyphus/data/firefox,1.8.1,nightly-win32.data,v  <--  firefox,1.8.1,nightly-win32.data
new revision: 1.4; previous revision: 1.3
done
Checking in data/firefox,1.8.1,opt.data;
/cvsroot/mozilla/testing/sisyphus/data/firefox,1.8.1,opt.data,v  <--  firefox,1.8.1,opt.data
new revision: 1.3; previous revision: 1.2
done
Checking in data/firefox,1.8.1,too-much-gc,debug.data;
/cvsroot/mozilla/testing/sisyphus/data/firefox,1.8.1,too-much-gc,debug.data,v  <--  firefox,1.8.1,too-much-gc,debug.data
new revision: 1.2; previous revision: 1.1
done
Checking in data/firefox,1.8.1-test,debug.data;
/cvsroot/mozilla/testing/sisyphus/data/firefox,1.8.1-test,debug.data,v  <--  firefox,1.8.1-test,debug.data
new revision: 1.3; previous revision: 1.2
done
Checking in data/firefox,1.8.1-test,opt.data;
/cvsroot/mozilla/testing/sisyphus/data/firefox,1.8.1-test,opt.data,v  <--  firefox,1.8.1-test,opt.data
new revision: 1.3; previous revision: 1.2
done
Checking in data/firefox,1.9.0,debug.data;
/cvsroot/mozilla/testing/sisyphus/data/firefox,1.9.0,debug.data,v  <--  firefox,1.9.0,debug.data
new revision: 1.3; previous revision: 1.2
done
Checking in data/firefox,1.9.0,nightly-linux.data;
/cvsroot/mozilla/testing/sisyphus/data/firefox,1.9.0,nightly-linux.data,v  <--  firefox,1.9.0,nightly-linux.data
new revision: 1.4; previous revision: 1.3
done
Checking in data/firefox,1.9.0,nightly-mac.data;
/cvsroot/mozilla/testing/sisyphus/data/firefox,1.9.0,nightly-mac.data,v  <--  firefox,1.9.0,nightly-mac.data
new revision: 1.4; previous revision: 1.3
done
Checking in data/firefox,1.9.0,nightly-win32.data;
/cvsroot/mozilla/testing/sisyphus/data/firefox,1.9.0,nightly-win32.data,v  <--  firefox,1.9.0,nightly-win32.data
new revision: 1.4; previous revision: 1.3
done
Checking in data/firefox,1.9.0,opt.data;
/cvsroot/mozilla/testing/sisyphus/data/firefox,1.9.0,opt.data,v  <--  firefox,1.9.0,opt.data
new revision: 1.3; previous revision: 1.2
done
Checking in data/firefox,1.9.0,too-much-gc,debug.data;
/cvsroot/mozilla/testing/sisyphus/data/firefox,1.9.0,too-much-gc,debug.data,v  <--  firefox,1.9.0,too-much-gc,debug.data
new revision: 1.2; previous revision: 1.1
done
Checking in data/firefox,1.9.0-jprof,debug.data;
/cvsroot/mozilla/testing/sisyphus/data/firefox,1.9.0-jprof,debug.data,v  <--  firefox,1.9.0-jprof,debug.data
new revision: 1.2; previous revision: 1.1
done
Checking in data/firefox,1.9.0-jprof,opt.data;
/cvsroot/mozilla/testing/sisyphus/data/firefox,1.9.0-jprof,opt.data,v  <--  firefox,1.9.0-jprof,opt.data
new revision: 1.2; previous revision: 1.1
done
Checking in data/firefox,1.9.0-test,debug.data;
/cvsroot/mozilla/testing/sisyphus/data/firefox,1.9.0-test,debug.data,v  <--  firefox,1.9.0-test,debug.data
new revision: 1.3; previous revision: 1.2
done
Checking in data/firefox,1.9.0-test,opt.data;
/cvsroot/mozilla/testing/sisyphus/data/firefox,1.9.0-test,opt.data,v  <--  firefox,1.9.0-test,opt.data
new revision: 1.3; previous revision: 1.2
done
Checking in data/js,1.8.0,debug.data;
/cvsroot/mozilla/testing/sisyphus/data/js,1.8.0,debug.data,v  <--  js,1.8.0,debug.data
new revision: 1.3; previous revision: 1.2
done
Checking in data/js,1.8.0,opt.data;
/cvsroot/mozilla/testing/sisyphus/data/js,1.8.0,opt.data,v  <--  js,1.8.0,opt.data
new revision: 1.3; previous revision: 1.2
done
Checking in data/js,1.8.0-test,debug.data;
/cvsroot/mozilla/testing/sisyphus/data/js,1.8.0-test,debug.data,v  <--  js,1.8.0-test,debug.data
new revision: 1.3; previous revision: 1.2
done
Checking in data/js,1.8.0-test,opt.data;
/cvsroot/mozilla/testing/sisyphus/data/js,1.8.0-test,opt.data,v  <--  js,1.8.0-test,opt.data
new revision: 1.3; previous revision: 1.2
done
Checking in data/js,1.8.1,debug.data;
/cvsroot/mozilla/testing/sisyphus/data/js,1.8.1,debug.data,v  <--  js,1.8.1,debug.data
new revision: 1.3; previous revision: 1.2
done
Checking in data/js,1.8.1,opt.data;
/cvsroot/mozilla/testing/sisyphus/data/js,1.8.1,opt.data,v  <--  js,1.8.1,opt.data
new revision: 1.3; previous revision: 1.2
done
Checking in data/js,1.8.1,too-much-gc,debug.data;
/cvsroot/mozilla/testing/sisyphus/data/js,1.8.1,too-much-gc,debug.data,v  <--  js,1.8.1,too-much-gc,debug.data
new revision: 1.2; previous revision: 1.1
done
Checking in data/js,1.8.1-test,debug.data;
/cvsroot/mozilla/testing/sisyphus/data/js,1.8.1-test,debug.data,v  <--  js,1.8.1-test,debug.data
new revision: 1.3; previous revision: 1.2
done
Checking in data/js,1.8.1-test,opt.data;
/cvsroot/

Comment 5

[Bob Clary [:bc] (inactive)]

Checking in post-process-logs.pl;
/cvsroot/mozilla/js/tests/post-process-logs.pl,v  <--  post-process-logs.pl
new revision: 1.10; previous revision: 1.9
done
Checking in process-logs.sh;
/cvsroot/mozilla/js/tests/process-logs.sh,v  <--  process-logs.sh
new revision: 1.3; previous revision: 1.2
done
Checking in runtests.sh;
/cvsroot/mozilla/js/tests/runtests.sh,v  <--  runtests.sh
new revision: 1.12; previous revision: 1.11
done
Checking in test-browser.sh;
/cvsroot/mozilla/js/tests/test-browser.sh,v  <--  test-browser.sh
new revision: 1.9; previous revision: 1.8
done
Checking in test-shell.sh;
/cvsroot/mozilla/js/tests/test-shell.sh,v  <--  test-shell.sh
new revision: 1.9; previous revision: 1.8
done
Checking in test.sh;
/cvsroot/mozilla/js/tests/test.sh,v  <--  test.sh
new revision: 1.7; previous revision: 1.6
done

Comment 6

[Bob Clary [:bc] (inactive)]

Attachment: sisyphus buildbot configure patch

This adds the TEST_DIR to the buildbot environment since Windows fails to load the .bash_profile when invoking cygwin's bash. I did it for all of the platforms as well.

I also did a minor change to not call the test script via ./tests/mozilla.org/js/runtests.sh since that ends up with an extra . in the log file name with the new configuration. It shouldn't be a problem.

Comment 7

[Bob Clary [:bc] (inactive)]

/cvsroot/mozilla/tools/buildbot-configs/testing/sisyphus/sisyphus.py,v  <--  sisyphus.py
new revision: 1.8; previous revision: 1.7

Comment 8

[(not currently active) Ted Mielczarek]

Mass move of Sisyphus bugs to Testing : Sisyphus. Filter on SisyphusMassMove to ignore.