426453 - Wrong plugin icon size used

Status: RESOLVED FIXED

(Firefox :: Theme, defect)

Description

[Michael Monreal [:micmon]]

The plugin notification uses the the large (32x32) icon where it should use the small (16x16) one.

Comment 1

[Michael Monreal [:micmon]]

Attachment: Screenshot

Shows caled down icon and 16x16 icon to compare

Comment 2

[Reed Loden [:reed]]

We need a 16x16 plugin icon to fix this... It affects all platforms.

Comment 3

[Michael Monreal [:micmon]]

The 16x16 plugin icon should already be there somewhere... if not I can attach it again.

Comment 4

[Reed Loden [:reed]]

I see a 16x16 version as part of toolkit/themes/gnomestripe/mozapps/extensions/viewButtons.png, but I need a standalone version of it.

Comment 5

[Michael Monreal [:micmon]]

Attachment: Plugins 16x16

No problem, here it is

Comment 6

[Reed Loden [:reed]]

Mossop, thoughts on where this icon should go and what name to use for it? Maybe toolkit/themes/*stripe/mozapps/plugins/pluginGeneric-16.png or something? dunno... :/

Comment 7

[Dave Townsend [:mossop]]

Variant naming seems to be pretty inconsistent but I think the name you have there is sensible.

Comment 8

[Reed Loden [:reed]]

faaborg, need 16x16 icons for winstripe and pinstripe for this, too.

Comment 9

[Alex Faaborg [:faaborg] (Firefox UX)]

Attachment: Aero plugin icon

Comment 10

[Alex Faaborg [:faaborg] (Firefox UX)]

Attachment: Luna plugin icon

Comment 11

[Alex Faaborg [:faaborg] (Firefox UX)]

Stephen: can you post the 16x16 plugin icon for proto

Comment 12

[Kai Liu]

I thought the 16x16 plugin icon already existed in browser/preferences for use in the handler picker?

Comment 13

[Stephen Horlander [:shorlander]]

Yes, we already have it at: http://mxr.mozilla.org/seamonkey/source/browser/themes/pinstripe/browser/preferences/plugin.png

Comment 14

[Reed Loden [:reed]]

I can't use an icon from browser/ for something in toolkit/, so I might just move the icon over to toolkit and update both places to use that icon so that we don't have two copies of the same thing.

Comment 15

[Reed Loden [:reed]]

Comment on attachment 316565 [details]
Plugins 16x16

Requesting approval to land this for gnomestripe. winstripe just got this landed earlier tonight.

Comment 16

[Damon Sicore (:damons)]

Comment on attachment 316565 [details]
Plugins 16x16

a1.9+=damons

Comment 17

[Reed Loden [:reed]]

RCS file: /cvsroot/mozilla/toolkit/themes/gnomestripe/mozapps/plugins/pluginGeneric-16.png,v
done
Checking in toolkit/themes/gnomestripe/mozapps/plugins/pluginGeneric-16.png;
/cvsroot/mozilla/toolkit/themes/gnomestripe/mozapps/plugins/pluginGeneric-16.png,v  <--  pluginGeneric-16.png
initial revision: 1.1
done

Comment 18

[Reed Loden [:reed]]

Checking in toolkit/themes/gnomestripe/mozapps/jar.mn;
/cvsroot/mozilla/toolkit/themes/gnomestripe/mozapps/jar.mn,v  <--  jar.mn
new revision: 1.13; previous revision: 1.12
done

Comment 19

[Reed Loden [:reed]]

Attachment: patch - v1

This finishes moving the icon to toolkit and swaps the use of the 32x32 icon to the 16x16 one.

Comment 20

[Asaf Romano (gone)]

Comment on attachment 319763 [details] [diff] [review]
patch - v1

r=mano

Comment 21

[Reed Loden [:reed]]

Comment on attachment 319763 [details] [diff] [review]
patch - v1

Simple patch to use the correct icon for plugin notification bar.

Comment 22

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 319763 [details] [diff] [review]
patch - v1

a1.9=beltzner

Comment 23

[Reed Loden [:reed]]

Checking in browser/base/content/browser.js;
/cvsroot/mozilla/browser/base/content/browser.js,v  <--  browser.js
new revision: 1.1032; previous revision: 1.1031
done
Checking in browser/themes/gnomestripe/browser/jar.mn;
/cvsroot/mozilla/browser/themes/gnomestripe/browser/jar.mn,v  <--  jar.mn
new revision: 1.80; previous revision: 1.79
done
Checking in browser/themes/gnomestripe/browser/preferences/applications.css;
/cvsroot/mozilla/browser/themes/gnomestripe/browser/preferences/applications.css,v  <--  applications.css
new revision: 1.4; previous revision: 1.3
done
Removing browser/themes/gnomestripe/browser/preferences/plugin.png;
/cvsroot/mozilla/browser/themes/gnomestripe/browser/preferences/plugin.png,v  <--  plugin.png
new revision: delete; previous revision: 1.4
done
Checking in browser/themes/pinstripe/browser/jar.mn;
/cvsroot/mozilla/browser/themes/pinstripe/browser/jar.mn,v  <--  jar.mn
new revision: 1.89; previous revision: 1.88
done
Checking in browser/themes/pinstripe/browser/preferences/applications.css;
/cvsroot/mozilla/browser/themes/pinstripe/browser/preferences/applications.css,v  <--  applications.css
new revision: 1.4; previous revision: 1.3
done
Removing browser/themes/pinstripe/browser/preferences/plugin.png;
/cvsroot/mozilla/browser/themes/pinstripe/browser/preferences/plugin.png,v  <--  plugin.png
new revision: delete; previous revision: 1.3
done
Checking in browser/themes/winstripe/browser/jar.mn;
/cvsroot/mozilla/browser/themes/winstripe/browser/jar.mn,v  <--  jar.mn
new revision: 1.97; previous revision: 1.96
done
Checking in browser/themes/winstripe/browser/preferences/applications.css;
/cvsroot/mozilla/browser/themes/winstripe/browser/preferences/applications.css,v  <--  applications.css
new revision: 1.3; previous revision: 1.2
done
Removing browser/themes/winstripe/browser/preferences/plugin.png;
/cvsroot/mozilla/browser/themes/winstripe/browser/preferences/plugin.png,v  <--  plugin.png
new revision: delete; previous revision: 1.5
done
Checking in toolkit/themes/pinstripe/mozapps/jar.mn;
/cvsroot/mozilla/toolkit/themes/pinstripe/mozapps/jar.mn,v  <--  jar.mn
new revision: 1.28; previous revision: 1.27
done
RCS file: /cvsroot/mozilla/toolkit/themes/pinstripe/mozapps/plugins/pluginGeneric-16.png,v
done
Checking in toolkit/themes/pinstripe/mozapps/plugins/pluginGeneric-16.png;
/cvsroot/mozilla/toolkit/themes/pinstripe/mozapps/plugins/pluginGeneric-16.png,v  <--  pluginGeneric-16.png
initial revision: 1.1
done