426980 - When zooming html or mathml text embed in svg as foreignObject, scaling factor seems to be larger, then for normal html, mathml of svg text

Status: RESOLVED FIXED

(Core :: SVG, defect)

Description

[Vladislav]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9b5) Gecko/2008032620 Firefox/3.0b5
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9b5) Gecko/2008032620 Firefox/3.0b5

Font size of any text in svg embed as foreignObject, when zoomed is scaled by larger factor, then normal text. Try to zoom
<p>Test</p>
<svg>
<switch>
<foreignObject>
<p>Test</p>
</foreignObject>
</switch>
</svg>

Reproducible: Always

Steps to Reproduce:
1.open a document with text in html and text embed in svg
2.zoon io or out
3.see the result
Actual Results:  
font-size in svg is larger

Expected Results:  
font-size should be magnified in the same way for any text

Comment 1

[Vladislav]

Attachment: zooming text in svg

Try to zoom in or out

Comment 2

[Jesse Ruderman]

I can reproduce the bug using a Mac trunk build.

Comment 3

[Robert Longson [:longsonr]]

We're scaling twice. The foreign object scales its content via GetCanvasTM which scales as the outer svg TM changes. But for foreignObject the content scales itself too.

Not sure how to fix it. I tried simply premultiplying by the inverse scaling in nsSVGForeignObject::PaintSVG. This makes the text zoom OK but it eventually exceeds the foreign object bounding box and gets clipped.

Should the mRect for the covered region of a foreignObject change when you zoom?

Comment 4

[Robert Longson [:longsonr]]

Attachment: WIP patch

Comment 5

[Vladislav]

Printing needs also to be fixed.

Comment 6

[Robert Longson [:longsonr]]

Attachment: patch

Comment 7

[Robert Longson [:longsonr]]

Comment on attachment 313947 [details] [diff] [review]
patch

My mistake, nothing wrong with this one as far as I can tell.

Comment 8

[Jonathan Watt [:jwatt]]

Comment on attachment 313947 [details] [diff] [review]
patch

Can you change the comment to something like:

  // GetCanvasTM includes a device pixel to CSS pixel scaling. Since non-SVG
  // content takes care of this itself, we need to remove this pre-scaling from
  // the matrix returned by GetTMIncludingOffset before painting our children.

Comment 9

[Robert Longson [:longsonr]]

Attachment: review comment addressed

Comment 10

[Robert Longson [:longsonr]]

Zooming and foreignObjects been new cool fx 3 features really need to work together properly.

Comment 11

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 314059 [details] [diff] [review]
review comment addressed

a1.9=beltzner

Comment 12

[Robert Longson [:longsonr]]

checked in.

Comment 13

[Vladislav]

Attachment: x-position changes when zooming

Comment 14

[Vladislav]

IMozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9pre) Gecko/2008040907 Minefield/3.0pre

In 3.0pre x-position remains the same, but should be shifted.

Comment 15

[Robert Longson [:longsonr]]

(In reply to comment #14)
> IMozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9pre) Gecko/2008040907
> Minefield/3.0pre
> 
> In 3.0pre x-position remains the same, but should be shifted.
> 

Please raise any additional issue(s) in new bugs.