Closed
Bug 427216
Opened 16 years ago
Closed 16 years ago
Make tools menu popup match other applications
Categories
(Other Applications :: DOM Inspector, defect)
Other Applications
DOM Inspector
Tracking
(Not tracked)
VERIFIED
FIXED
People
(Reporter: Fallen, Assigned: Fallen)
Details
(Keywords: verified1.8.1.15)
Attachments
(1 file)
2.37 KB,
patch
|
dbo
:
review+
timeless
:
review+
dmosedale
:
superreview+
samuel.sidler+old
:
approval1.8.1.15+
|
Details | Diff | Splinter Review |
Currently the name for our tools menupopup is "toolsPopup", which seems to be historical naming from xpfe times. Most applications now call it menu_ToolsPopup. Changing this will allow extensions that work on multiple applications to use only one overlay to add to the tools menu. An lxr search showed that inspector is the only (overlaid) user of the toolsPopup, so changing this there too.
Attachment #313801 -
Flags: review?(daniel.boelzle)
Comment 1•16 years ago
|
||
Comment on attachment 313801 [details] [diff] [review] Fix v1 r=dbo for the calendar part
Attachment #313801 -
Flags: review?(daniel.boelzle) → review+
Comment on attachment 313801 [details] [diff] [review] Fix v1 http://mxr-stage.mozilla.org/mozilla/search?string=%22toolsPopup%22&find=xul you should probably tell the venkman people that you now come under the firefox category
Attachment #313801 -
Flags: review+
Assignee | ||
Comment 3•16 years ago
|
||
Venkman should be fine, since http://mxr-stage.mozilla.org/mozilla/source/extensions/venkman/resources/content/venkman-overlay.xul#77 also tries to overlay menu_ToolsPopup automatically. What sort of approvals do I need to check in the dom inspector part on branch and head?
Assignee | ||
Updated•16 years ago
|
Assignee: philipp → nobody
Status: ASSIGNED → NEW
Component: Sunbird Only → DOM Inspector
Product: Calendar → Other Applications
QA Contact: sunbird → dom-inspector
Assignee | ||
Comment 4•16 years ago
|
||
Comment on attachment 313801 [details] [diff] [review] Fix v1 Requesting approval for MOZILLA_1_8_BRANCH, since calendar has a cross-commit policy
Attachment #313801 -
Flags: approval1.8.1.15?
Comment 5•16 years ago
|
||
Philipp, moving this bug to DOMi cleared your assignee status. If you're still working on this bug, you'll have to accept it again. (Or did I misunderstand?)
Assignee: nobody → philipp
Comment 6•16 years ago
|
||
DOMi requires sr as well.
Assignee | ||
Updated•16 years ago
|
Status: NEW → ASSIGNED
Comment 7•16 years ago
|
||
Comment on attachment 313801 [details] [diff] [review] Fix v1 sr=dmose
Attachment #313801 -
Flags: superreview+
Comment 8•16 years ago
|
||
Comment on attachment 313801 [details] [diff] [review] Fix v1 Approved for 1.8.1.15. a=ss for Sunbird-only change.
Attachment #313801 -
Flags: approval1.8.1.15? → approval1.8.1.15+
Assignee | ||
Comment 9•16 years ago
|
||
Checked in on HEAD and MOZILLA_1_8_BRANCH -> FIXED
Status: ASSIGNED → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
Assignee | ||
Comment 10•16 years ago
|
||
DOMi from CVS still works in latest builds. Using DOMi to inspect the menuitem, the popup name has changed -> VERIFIED
Status: RESOLVED → VERIFIED
Updated•16 years ago
|
Keywords: fixed1.8.1.15
Comment 11•16 years ago
|
||
Verified on 1.8.1.15 nightly branch. Menu name changed. Used DOMi similar to comment 10.
Keywords: fixed1.8.1.15 → verified1.8.1.15
You need to log in
before you can comment on or make changes to this bug.
Description
•