Closed Bug 42734 Opened 24 years ago Closed 24 years ago

How many characters in "hello" assert in Content Sink

Categories

(Core :: DOM: HTML Parser, defect, P3)

Product:
Core
Component:
DOM: HTML Parser
Type:
defect

Tracking

()

Status:
RESOLVED INVALID

People

(Reporter: pollmann, Assigned: pollmann)

Details

(Whiteboard: fix in hand)

Attachments

(1 file)

Proposed fix
1.84 KB, patch
Details | Diff | Splinter Review 
I got an assert today in HTMLContentSink::AddDocTypeDecl

Basically, we strip characters from a string, then get the first char at the 
string without checking it's length to see if it's non-zero.  In some cases it 
may be zero length, and this is causing the assert.

Will attach a patch shortly.  Harish, can you review it?  Or if you would prefer 
to check it in, that's great too.  :)
Attached patch Proposed fix — — Splinter Review 

    
  
Status: NEW → ASSIGNED
Summary: How many characters in "hello" error in Content Sink → How many characters in "hello" assert in Content Sink
Whiteboard: fix in hand
Target Milestone: --- → M17

    
    

    
  
I've heard of at least two other people who have fixes for this, one of which 
is better, so I'm going to close this one out (won't get lost because the 
asserts are too obvious!)
Status: ASSIGNED → RESOLVED
Closed: 24 years ago
Resolution: --- → INVALID

    
    

    
  
Asserts are fixed now.

    
    

    
  
updated qa contact.
QA Contact: janc → bsharma

    
  
QA Contact: bsharma → moied

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: