Closed Bug 428407 Opened 16 years ago Closed 16 years ago

Sisyphus - should use unittest account on unittest machines

Categories

(Testing Graveyard :: Sisyphus, defect)

x86
All
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: bc, Assigned: bc)

References

Details

Attachments

(1 file)

Currently, Sisyphus has anonymous pserver set in set-build-env.sh for checking out from cvs-mirror. This causes the unittest machines to lag the actual checkins by 15+ minutes. set-build-env.sh should be able to detect whether it has a unittest private key and use that when running on the unittest boxes.
Flags: in-testsuite-
Flags: in-litmus-
Attached patch patchSplinter Review
If CVSROOT already set use that, else if "unittest" account exists in id_dsa.pub, then use unittest else use anonymous.
Attachment #315258 - Flags: review?(rcampbell)
Comment on attachment 315258 [details] [diff] [review]
patch

This makes me a little uneasy since you could see a test failure due to cvs update lag, but since they're automated, they would clear on the next update.
Attachment #315258 - Flags: review?(rcampbell) → review+
Actually, the current setup _always_ uses the anon pserver. This just allows it to use unittest if it is available.

/cvsroot/mozilla/testing/sisyphus/bin/set-build-env.sh,v  <--  set-build-env.sh
new revision: 1.7; previous revision: 1.6
Status: ASSIGNED → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
Mass move of Sisyphus bugs to Testing : Sisyphus. Filter on SisyphusMassMove to ignore.
Component: Testing → Sisyphus
Flags: in-litmus-
Product: Core → Testing
QA Contact: testing → sisyphus
Product: Testing → Testing Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: