428811 - ChatZilla appends underscores infinitely, when nickname is unavailable on server

Status: RESOLVED FIXED

(Other Applications :: ChatZilla, defect)

Description

[Mitchell Field [:Mitch]]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9pre) Gecko/2008041206 Minefield/3.0pre
Build Identifier: ChatZilla 0.9.81

If a nickname is already in use on a server, ChatZilla appends an underscore to the previously-tried nickname, in an attempt to choose a unique, unused nickname. There is no automatic stop condition for this process.

Reproducible: Always

Comment 1

[Mitchell Field [:Mitch]]

Attachment: Patch v1.0

This patch limits retrying to the number of nicknames on the nickname list plus 3.

Comment 2

[:Gijs (he/him)]

Comment on attachment 315389 [details] [diff] [review]
Patch v1.0

You broke the nick list version by moving the changeNick bits into the else if. Now, if |tryList| is true, it'll never actually change nickname, as far as I can tell. r- on that.

Comment 3

[Mitchell Field [:Mitch]]

Attachment: Patch v1.1

This patch addresses the previous comments.

Comment 4

[:Gijs (he/him)]

Is it just me, or does using the nickname list, even with this patch, go on indefinitely? Is that intended behaviour? Silver, got an opinion on this one?

Comment 5

[James Ross]

The code says otherwise; it'll try each nickname in the list once and only once, starting at the current nick (if in the list), or the first (otherwise).

Comment 6

[:Gijs (he/him)]

Comment on attachment 315759 [details] [diff] [review]
Patch v1.1

Alright, then this seems OK. r=me, assuming this tested well.

Comment 7

[James Ross]

Checked in --> FIXED.