Closed Bug 428924 Opened 16 years ago Closed 16 years ago

Windows icon: library window navigation icons can not reference toolbar.png anymore

Categories

(Firefox :: Theme, defect)

Product:
Firefox
Component:
Theme
Platform:
All
Windows XP
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
Firefox 3

People

(Reporter: faaborg, Assigned: dao)

References

Details

Attachments

(1 file, 2 obsolete files)

patch
2.70 KB, patch
asaf
: review+
mconnor
: approval1.9+
Details | Diff | Splinter Review 
Previously the navigation buttons in the library window have been located in toolbar.png.  We are switching the icons in toolbar.png to be round so that they look correct when the user is in icons + text mode.  The navigation icons for the library window will be:

/winstripe/browser/places/libraryNavigation.png
/winstripe/browser/places/libraryNavigation-aero.png

This files will be included in the next icon drop.  I'll update this bug when they have landed.
Summary: Library window navigation icons can not reference toolbar.png anymore → Windows icon: library window navigation icons can not reference toolbar.png anymore
Alex: what will the dimensions and image format be?
Mano: can you patch the appropriate CSS for this?
Flags: blocking-firefox3+
Attached image libraryNavigation.png (obsolete) — 

    
    

    
  

      
      
      
      

        Attached image
          
        libraryNavigation-aero.png (obsolete)
        — 
      

    


  

    
    

    
  
Land these two icons to /winstripe/browser/places

    
  
Assignee: nobody → mano
Target Milestone: --- → Firefox 3

    
    

    
  
I'll find an owner for this, Mano's got a ton on his plate already.
Assignee: mano → mconnor

    
    

    
  
should be trivial
Assignee: mconnor → dao

    
    

    
  

      
      
      
      

        Attached patch
          
          
        patch
        — 
          — Splinter Review
      

    


  

        Attachment #315915 -
        Attachment is obsolete: true

        Attachment #315916 -
        Attachment is obsolete: true

        Attachment #316579 -
        Flags: review?(gavin.sharp)

    
  

        Attachment #316579 -
        Flags: review?(gavin.sharp) → review?(dietrich)

    
    

    
  
Comment on attachment 316579 [details] [diff] [review]
patch

r=mano

        Attachment #316579 -
        Flags: review?(dietrich) → review+

    
  

        Attachment #316579 -
        Flags: approval1.9?

    
    

    
  
Comment on attachment 316579 [details] [diff] [review]
patch

a=mconnor on behalf of 1.9 drivers

        Attachment #316579 -
        Flags: approval1.9? → approval1.9+
Keywords: checkin-needed
Whiteboard: [has patch][has reviews]

    
    

    
  
mozilla/browser/themes/winstripe/browser/places/organizer.css 	1.12
Status: NEW → RESOLVED
Closed: 16 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Whiteboard: [has patch][has reviews]

    
    

    
  
Why is the new image not a chrome URL, like all others in organizer.css?

    
    

    
  
URLs in a CSS file are relative to that file by default, which makes the path redundant in this case. Is there anything wrong with that?

    
    

    
  
(In reply to comment #12)
> URLs in a CSS file are relative to that file by default, which makes the path
> redundant in this case. Is there anything wrong with that?
> 

Nah, just wondering. I don't know about coding style in the theme and consistency rules, though.

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: