Closed Bug 429149 Opened 16 years ago Closed 16 years ago

Profile image should have a Tango style

Categories

(Firefox :: Theme, enhancement)

Product:
Firefox
Component:
Theme
Platform:
x86
Linux
Type:
enhancement
Priority:
Not set
Severity:
normal

Tracking

()

Status:
VERIFIED FIXED
Milestone:
Firefox 3.6a1

People

(Reporter: adelfino, Assigned: Dolske)

References

Details

(Keywords: polish, verified1.9.1, Whiteboard: [polish-easy][polish-visual][polish-p4])

Attachments

(4 files, 1 obsolete file)

16x16 profile icon
736 bytes, image/png
faaborg
: ui-review+
Details
source SVG in case alterations are needed
5.62 KB, image/svg+xml
Details
Patch v.1
2.59 KB, patch
Gavin
: review+
beltzner
: approval1.9.1+
Details | Diff | Splinter Review
Screenshot (patch v.1)
27.19 KB, image/png
faaborg
: ui-review+
Details 
User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9pre) Gecko/2008041509 Minefield/3.0pre
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9pre) Gecko/2008041509 Minefield/3.0pre

Profile image should have a Tango style.

Please see screenshot.png

Reproducible: Always
Attached image Screenshot. (obsolete) — 

    
  
Version: unspecified → Trunk

    
  
Blocks: 381206

    
    

    
  
Image is: profileicon.png

    
    

    
  
Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9pre) Gecko/2008042204 Minefield/3.0pre

Can confirm.

    
  
Status: UNCONFIRMED → NEW
Ever confirmed: true

    
    

    
  

      
      
      
      

        Attached image
          
        16x16 profile icon
        — 
      

    


  
Keywords: polish
Whiteboard: [polish-easy][polish-visual]

    
    

    
  
Comment on attachment 318110 [details]
16x16 profile icon

I'm not totally familiar with standard visual appearance on linux for user profiles, but assuming this is the correct style, ui-r+

either way we should get this landed so we can make changes in the future with an icon drop in, and this image is way better than the XP icon on Linux.

    
    

    
  

      
      
      
      

        Attached patch
          
          
        Patch v.1
        — 
          — Splinter Review
      

    


  
Assignee: nobody → dolske
Status: NEW → ASSIGNED

        Attachment #350605 -
        Flags: review?(gavin.sharp)

    
    

    
  

      
      
      
      

        Attached image
          
        Screenshot (patch v.1)
        — 
      

    


  
This uses the icon from comment 4.

        Attachment #315793 -
        Attachment is obsolete: true

        Attachment #350606 -
        Flags: ui-review?(faaborg)

        Attachment #350605 -
        Flags: review?(gavin.sharp) → review+

        Attachment #350606 -
        Flags: ui-review?(faaborg) → ui-review+

    
  

        Attachment #350605 -
        Flags: approval1.9.1?

    
    

    
  
Pushed http://hg.mozilla.org/mozilla-central/rev/9f1757e3559e
Status: ASSIGNED → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 3.2a1

        Attachment #350605 -
        Flags: approval1.9.1? → approval1.9.1+

    
    

    
  
Verified fix on Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.2a1pre) Gecko/20090122 Minefield/3.2a1pre 
and Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.1b3pre) Gecko/20090122 Shiretoko/3.1b3pre
Status: RESOLVED → VERIFIED
Keywords: fixed1.9.1 → verified1.9.1

    
    

    
  
This bug's priority relative to the set of other polish bugs is:
P4 - Polish issue that is rarely encountered, and is easily identifiable.
Whiteboard: [polish-easy][polish-visual] → [polish-easy][polish-visual][polish-p4]

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: