429241 - \x... and \u... in RegExp parsed wrong if not followed by enough hex digits

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[x0]

\x and \u must always be followed by exactly 2 resp. 4 hexadecimal digits to form a Hex- or UnicodeEscapeSequence. If they are not, then they should be an IdentityEscape that resolves to plain x resp. u.

ParseTerm, CalculateBitmapSize and ProcessCharSet do that wrong and treat them as \0 instead (or the partly calculated character number if followed by too few hexadecimal digits). In CalculateBitmapSize and ProcessCharSet the (src < end) test wouldn't be necessary, because it is known there that a ']' follows at the end.

CalculateBitmapSize and ProcessCharSet are also wrong if an uncomplete \x... or \u... isn't at the end, because they treat the backslash literally and ignore the x or u. Instead it should be treated as IdentityEscape and thus the backslash be ignored. ParseTerm does that correctly.

Comment 1

[x0]

Attachment: patch

Comment 2

[x0]

Attachment: testcase for testsuite

Comment 3

[Brian Crowder]

Comment on attachment 316105 [details] [diff] [review]
patch

This should probably wait to land in a dot-release, though.

Comment 4

[Nochum Sossonko [:Natch]]

x0: you should put the keyword 'checkin-needed' once the patch is indeed ready to be checked in.

Comment 5

[Nochum Sossonko [:Natch]]

These bugs are all part of a search I made for js bugs that are getting lost in transit:

http://tinyurl.com/jsDeadEndBugs

They all have a review+'ed, non-obsoleted patch and are not marked fixed-in-tracemonkey or checkin-needed but have not seen any activity in 300 days. Some of these got lost simply because the assignee/patch provider never requested a checkin, or just because they were forgotten about.

Comment 6

[Nochum Sossonko [:Natch]]

Is this still an issue with YARR?

Comment 7

[Chris Leary [:cdleary] (not checking bugmail)]

(In reply to comment #6)
> Is this still an issue with YARR?

Doesn't appear to be, as the testcase passes. I'm going to steal assignment so I remember to review and check in the test case post-FF4.

Comment 8

[Tom S [:evilpie]]

Should i do it?

Comment 9

[Chris Leary [:cdleary] (not checking bugmail)]

http://hg.mozilla.org/integration/mozilla-inbound/rev/a445e447d222

Comment 10

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/a445e447d222