429388 - vfychain.main leaks memory

Status: RESOLVED FIXED

(NSS :: Libraries, defect)

Description

[Alexei Volkov]

Attachment: Use PORT_Free to deallocate the memory.

Function main leaks memory allocated to keep data for certDir, progName, oidStr, revConfig and password.

Comment 1

[Nelson Bolyard (seldom reads bugmail)]

Comment on attachment 316100 [details] [diff] [review]
Use PORT_Free to deallocate the memory.

>+    if (progName)
>+        PORT_Free(progName);
>+    if (certDir)
>+        PORT_Free(certDir);
>+    if (oidStr)
>+        PORT_Free(oidStr);
>+    if (revConfig) 
>+        PORT_Free(revConfig);
>+    if (password)
>+        PORT_Free(password);

PORT_Free checks its argument for NULL, making the checks added above 
redundant.  I'd prefer not to have those redundant checks.

Comment 2

[Nelson Bolyard (seldom reads bugmail)]

Comment on attachment 316100 [details] [diff] [review]
Use PORT_Free to deallocate the memory.

r+ once the redundant checks are removed.

Comment 3

[Alexei Volkov]

Patch is integrated.