42958 - nsPSMComponent.h has a dangling reference to security.properties

Status: VERIFIED FIXED

(Core Graveyard :: Security: UI, defect, P3)

Description

[Peter "jag" Annema]

Ben, seems you forgot one.

http://lxr.mozilla.org/seamonkey/source/extensions/psm-glue/src/nsPSMComponent.h
#32

-#define SECURITY_STRING_BUNDLE_URL 
"chrome://navigator/locale/security.properties"
+#define SECURITY_STRING_BUNDLE_URL 
"chrome://communicator/locale/security.properties"

Comment 1

[Peter "jag" Annema]

*** Bug 42920 has been marked as a duplicate of this bug. ***

Comment 2

[Peter "jag" Annema]

As noted in bug 42920, the "Security Warning" (form submit) dialog doesn't show 
text, and garbage as a title.

After placing a copy of security.properties in navigator/locale, it works fine 
again.

Comment 3

[Cyril Bortolato]

*** Bug 42985 has been marked as a duplicate of this bug. ***

Comment 4

[John Unruh]

*** Bug 43037 has been marked as a duplicate of this bug. ***

Comment 5

[John Unruh]

*** Bug 43027 has been marked as a duplicate of this bug. ***

Comment 6

[jlarsen]

*** Bug 43027 has been marked as a duplicate of this bug. ***

Comment 7

[jlarsen]

It appears that chrome://navigator/locale/security.properties
and chrome://navigator/locale/security/security.properties were two seperate 
files in last weeks builds. 
Navigator contained Security warnings such as

Title=Security Warning
MixedContentMessage=You have requested a secure document that contains some 
insecure information.
LeaveSiteMessage=You have requested an insecure document. The document and any 
information you send back could be observed by a third party while in transit.
EnterSiteMessage=You have requested a secure document. The document and any 
information you send back are encrypted for privacy while in transit.
PostToInsecure=Warning! Although this document is secure, the information you 
have submitted is insecure and could be observed by a third party while in 
transit. If you are submitting passwords, credit card numbers, or other 
information you would like to keep private, it would be safer for you to cancel 
the submission.
PostToInsecureFromInsecure=Any information you submit is insecure and could be 
observed by a third party while in transit. If you are submitting passwords, 
credit card numbers, or other information you would like to keep private, it 
would be safer for you to cancel the submission. 
DontShowAgain=Show Me This Alert Next Time.
FindText=Please find the Personal Security Manager application

While Communicator just contains

Yes = Yes
No = No
Titleline = Internet Security
CheckMessage = Remember this decision
EnableCapabilityQuery = A script from "%1$s" has requested enhanced privileges. 
You should grant these privileges only if you are comfortable downloading and 
executing a program from this source. Do you wish to allow these privileges?

(COMMENTS from files removed)

Comment 8

[jlarsen]

Typo I meant chrome://communicator/locale/security/security.properties

for the second entry :(

Comment 9

[Joseph Elwell]

This is really bad. With a new profile you can't get that popup to stop showing
up. So whenever I submit a form I get this annoying popup that doesn't say
anything.

Comment 10

[Peter "jag" Annema]

They are still two different files:
chrome/locales/en-US/communicator/security.properties
chrome/locales/en-US/communicator/security/security.properties

The first one was moved from navigator to communicator, that's all.

Comment 11

[Peter "jag" Annema]

Insert a "locale/" just after communicator/ in my previous comment :-)

In my mind, that part of the path doesn't make sense, hence the omission, but 
that's another topic.

Sorry for the spam.

Comment 12

[Peter "jag" Annema]

I guess I need to work on expressing myself...

My first comment was meant to be read as a fix for these problems.

The fix is very simple, change the word "navigator" to "communicator" on line 32 
of nsPSMComponent.h

Comment 13

[Peter "jag" Annema]

Attachment: [PATCH] navigator -> communicator

Comment 14

[WD]

*** Bug 43046 has been marked as a duplicate of this bug. ***

Comment 15

[Cyril Bortolato]

*** Bug 43128 has been marked as a duplicate of this bug. ***

Comment 16

[Stuart Parmenter]

reassigning

Comment 17

[Stuart Parmenter]

checked in Peter's fix.  thanks.

Comment 18

[John Unruh]

Verified.

Comment 19

[John Unruh]

Mass changing Security:Crypto to PSM

Comment 20

[John Unruh]

Mass changing Security:Crypto to PSM