42991 - nsXULTemplateBuilder.cpp references invalid RDF elemant

Status: VERIFIED FIXED

(Core Graveyard :: RDF, defect, P3)

Description

[Dan Mosedale (:dmosedale, :dmose)]

Specifically, kRDF_child: 

6513 #define TREE_PROPERTY_HACK 1
6514 #if defined(TREE_PROPERTY_HACK)
6515     if (! len) {
6516         // Some ever-present membership tests.
6517         mContainmentProperties.Add(kNC_child);
6518         mContainmentProperties.Add(kNC_Folder);
6519         mContainmentProperties.Add(kRDF_child);
6520     }
6521 #endif
6522 

The core RDF namespace doesn't have an property called child.  I couldn't find
any other obvious references to it in the tree just by using lxr.

Comment 1

[Chris Waterson]

dmose: could you try chopping it out to see if "anything breaks"? I think only 
rjc or I would've done something that relied on rdf:child, and my guess is that 
most of the stuff is done using nc:child now, anyway.

Comment 2

[Robert John Churchill]

Yeah, I think RDF#Child is merely historical and hopefully not actually used 
anywhere.

Comment 3

[Chris Waterson]

Allright. I'll remove it, and we can just hand tweak any datasources that still
rely on it working.

Comment 4

[Chris Waterson]

Attachment: rip out kRDF_child

Comment 5

[Chris Waterson]

rjc, r=?

Comment 6

[Robert John Churchill]

r=rjc  with pleasure

Comment 7

[Chris Waterson]

fix checked in

Comment 8

[Bradley Baetz (:bbaetz)]

VERIFIED that the patch was checked in...