430805 - [RFE] Permit to change the default free/busy attribute policy for all-day events

Status: VERIFIED FIXED

(Calendar :: Preferences, enhancement)

Description

[Laurent Bauvens]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; fr; rv:1.9b5) Gecko/2008032620 Firefox/3.0b5
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; fr; rv:1.8.1.13pre) Gecko/20080331 Sunbird/0.8

All-day events are marked by default with a 'free' attribute. To change this attribute, you must go into the menu 'Options' > 'Show Time As' and choose 'Busy'.

It would be nice to give to the user the possibility of changing the default all-day free/busy policy with the creation of a new preference key.

Reproducible: Always

Steps to Reproduce:
1.Create a new all-day event
2.Go to menu Options > Show Time As
Actual Results:  
Event is marked as 'Free'

Expected Results:  
Event is marked as 'Busy'

Comment 1

[Daniel Boelzle [:dbo]]

Attachment: patch

I think this enhancement makes sense; drive-by patch reading default from pref.

Comment 2

[Stefan Sitter [:ssitter]]

I don't think users should mess with strings like "TRANSPARENT" or "OPAQUE" via advanced preferences especially because comments are not visible in the UI. Setting it to e.g. "foobar" would mean invalid .ics is produced. In my opinion we should use just a boolean preference e.g. calendar.default.allday.showAsBusy with true/false. Mapping to "TRANSPARENT" or "OPAQUE" is done internally.

Comment 3

[Stefan Sitter [:ssitter]]

Maybe the default value for non all day events could be moved to preferences in the same step too.

Comment 4

[Daniel Boelzle [:dbo]]

This is an expert's setting, I think it's OK to use those values.

Comment 5

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Comment on attachment 319537 [details] [diff] [review]
patch


> function setShowTimeAs(allDay) {
>-    gShowTimeAs = allDay ? "TRANSPARENT" : "OPAQUE";
>+    gShowTimeAs = allDay ? getPrefSafe("calendar.allday.defaultTransparency", "TRANSPARENT") : "OPAQUE";
>     updateShowTimeAs();
> }
For bonus points, add () around the whole ?: condition.

r=philipp in any case

Comment 6

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

If there are no other values other than transparent and opaque, I think its not a bad idea to make it boolean, since even as an expert you don't have to mess with specific string values.

Comment 7

[Laurent Bauvens]

Wooh! This is the speediest patch action for a proposal I've ever seen ! :)

Thank you very much

Comment 8

[Daniel Boelzle [:dbo]]

I think there are good reasons why the RFC inventors have chosen terms instead of just a boolean value for that property. It makes the meaning more readable (instead of encoding it into the property's name) and leaves it open for future values.

Comment 9

[Daniel Boelzle [:dbo]]

(In reply to comment #3)
> Maybe the default value for non all day events could be moved to preferences in
> the same step too.

IMO this depends on whether there's really a use case for that (which I doubt).

Comment 10

[Daniel Boelzle [:dbo]]

Anyway, we could file a follow-up RFE if someone shows interest.

Checked in on HEAD and MOZILLA_1_8_BRANCH => FIXED.

Comment 11

[Andreas Treumann]

Checked in lightning build 2008062503 and Sunbird 20080624 -> VERIFIED.

Comment 12

[Fabi]

I think this patch really enhances Lightning! Good job! 

Is it planned to include this in the "not advanced" options? Because I still think that many users don't understand why their all-day events are not marked a busy.