Closed
Bug 432647
Opened 16 years ago
Closed 16 years ago
fennec loads with file:/// url on start up
Categories
(Firefox for Android Graveyard :: General, defect)
Tracking
(Not tracked)
VERIFIED
FIXED
People
(Reporter: blassey, Assigned: blassey)
Details
Attachments
(1 file)
997 bytes,
patch
|
mfinkle
:
review+
|
Details | Diff | Splinter Review |
on start up, fennec for maemo loads "file:///", ignoring the preference for a home page.
Assignee | ||
Comment 1•16 years ago
|
||
filters out empty string arguments and args that being with "-" as not valid uris
Attachment #320848 -
Flags: review?(mark.finkle)
Comment 2•16 years ago
|
||
Comment on attachment 320848 [details] [diff] [review] filters uris >+ var uri = cmdLine.getArgument(0); >+ >+ just 1 empty line is ok >+ if(uri !="" && uri[0] !='-'){ common mozilla JS style (used in Fx and inherited in fennec) is if (uri != "" && uri[0] !='-') { and no TABs >+ whereURI = cmdLine.resolveURI(); >+ if (whereURI) >+ whereURI = whereURI.spec; >+ } >+ } r+ with those changes
Attachment #320848 -
Flags: review?(mark.finkle) → review+
Comment 3•16 years ago
|
||
if (uri != "" && uri[0] != '-') { (forgot a space)
Comment 4•16 years ago
|
||
And...
>+ whereURI = cmdLine.resolveURI();
whereURI = cmdLine.resolveURI(uri);
Assignee | ||
Updated•16 years ago
|
Status: NEW → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
Comment 5•15 years ago
|
||
verified fixed on builds: Mozilla/5.0 (Windows; U; WindowsCE 5.2; en-US; rv:1.9.3a1pre) Gecko/20090817 Fennec/1.0a3pre Mozilla/5.0 (X11; U; Linux armv6l; en-US; rv:1.9.3a1pre) Gecko/20090817 Fennec/1.0b3pre
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•