432920 - Thunderbird fails to check that it is the default email client on startup

Status: RESOLVED FIXED

(Thunderbird :: General, defect)

Description

[Gary Kwong [:gkw] [:nth10sd] (NOT official MoCo now)]

Occurred on 10.4 Tiger, while testing Shredder Alpha 1 build 1 and on Vista SP1 as well.

Thunderbird fails to check that it is the default email client on startup. On Vista, I even made sure that I checked "Windows Mail" as the default prior to starting Thunderbird. I ended at the account wizard without Thunderbird ever asking me if Thunderbird was to become the default client.

On first run, as a comparison, Firefox does ask if it should be the default web browser, so the same should apply for Thunderbird.

Comment 1

[Rod Whiteley]

I tried it on Windows XP.  After setting up an account, the next restart of Thunderbird made it ask whether it should be the default.  It would be wrong for it to ask before any account is set up, because a default mail client with no account is useless.

Comment 3

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Gary, do you have multiple profile? I bet so. I can remember to a bug where that happens with multiple profiles. Could you run a test with a cleaned folder under Library?

Comment 4

[Gary Kwong [:gkw] [:nth10sd] (NOT official MoCo now)]

Henrik, fresh profile.

I must note that this happens on and off. Sometimes the dialog comes up, other times not. Pretty inconsistent to be honest. Also, Mail.app wasn't touched, and the 10.5 system was pretty fresh.

Comment 5

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Sure. But do you use multiple profiles? If not then it's a bit suspicious. Any idea why that only happens time by time? Any special conditions e.g. after a software update or others?

Comment 6

[Gary Kwong [:gkw] [:nth10sd] (NOT official MoCo now)]

No, no multiple profiles. No software update. And no idea why it only happens from time to time.

Comment 7

[Rain [:rain1] (inactive)]

As part of bug 430614, the startup situation does need to be improved.

Comment 8

[Rain [:rain1] (inactive)]

Attachment: fix v1

The code's a pain to look at in general :(

Comment 9

[David :Bienvenu]

Thx for the patch, Sid! Can you explain a little what the problem was? Is this a regression?

Comment 10

[Rain [:rain1] (inactive)]

I'm not sure where if it's a regression or not (it could be related to bug 438050), but what was happening was that the account wizard dialog was being opened asynchronously, immediately returning to the code that checks whether there's an account or not (the default client dialog only pops up if there's already an account configured).

Now I'm forcing things to be in order through a callback.

Comment 11

[Dan Mosedale (:dmosedale, :dmose)]

I don't think this is really a blocker because it's just not that painful for the user.  But it'd sure be nice to have; so marking wanted-thunderbird3+.

Comment 12

[David :Bienvenu]

Comment on attachment 333992 [details] [diff] [review]
fix v1

ok, thx, Sid.

Comment 13

[Rain [:rain1] (inactive)]

Note to testers: please start with a fresh profile. (This should work fine on all Windows installations at least -- others might me missing something that is required for the default client dialog to show.)

You should see the account wizard. If you create the account, you should see the default client dialog immediately after the account wizard finishes. If you don't, you shouldn't.

Comment 14

[Phil Ringnalda (:philor)]

http://hg.mozilla.org/comm-central/index.cgi/rev/72a87349675b

Comment 15

[[e-mail]]

Comment on attachment 333992 [details] [diff] [review]
fix v1

>+  setTimeout(function() { msgOpenAccountWizard(wizardCallback); }, 0);
Actually you can write this as
setTimeout(msgOpenAccountWizard, 0, wizardCallback);