433065 - remove support for -moz-pre-wrap

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, defect)

Description

[:Gavin Sharp [email: [e-mail]]]

See bug 418543. That bug removed a bunch of in-tree references, this bug is about removing support for it entirely.

Comment 1

[Daniel.S]

I think this'd be best before beta builds are released. It should also be possible to combine this with Bug 413141. Anyway, my last comment on this.

Comment 2

[Daniel.S]

Attachment: trying to remove -moz-pre-wrap

This patch should remove all remnants of -moz-pre-wrap, I hope it is correct.

Sorry for my spam earlier. I think I finally got it.

Comment 3

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 340635 [details] [diff] [review]
trying to remove -moz-pre-wrap

This looks ok, but there are some nsIDocumentEncoder.idl comments that could use fixing too, and this probably needs moa from dbaron.

Comment 4

[Daniel.S]

Attachment: v2

(In reply to comment #3)
> (From update of attachment 340635 [details] [diff] [review])
> This looks ok, but there are some nsIDocumentEncoder.idl comments that could
> use fixing too

There was only one line to be changed. However, I did a more careful search and found some appearances of moz-pre-wrap in htmlparser/tests and nsPlainTextSerializer.css - nothing special, though.

Should I ask for another sr here?

Comment 5

[Daniel.S]

Attachment: v3

Of course we want -moz-pre-wrap to go away...

Comment 6

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Comment on attachment 340722 [details] [diff] [review]
v3

r=dbaron

Comment 7

[Dão Gottwald [:dao]]

http://hg.mozilla.org/mozilla-central/rev/e57e250218c4

Comment 8

[[e-mail]]

So, this breaks three non-Firefox consumers...

Comment 9

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

I see two:
http://mxr.mozilla.org/comm-central/source/calendar/base/themes/winstripe/calendar-views.css#606
http://mxr.mozilla.org/comm-central/source/calendar/base/themes/pinstripe/calendar-views.css#606

What's your third?

Comment 10

[[e-mail]]

Actually I counted that as one "consumer"; my other two were:

http://mxr.mozilla.org/comm-central/source/mozilla/extensions/venkman/resources/content/venkman-output-base.css#58
http://mxr.mozilla.org/comm-central/source/mozilla/extensions/irc/xul/content/output-base.css#506

Comment 11

[[e-mail]]

My apologies, I didn't realise that bug 418543 had converted all consumers (at least, all the ones that were includeded in comm-central mxr at the time).

Comment 12

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

The two in comment 10 are fine, and should stay as they are, I think, since those extensions try to be compatible with old versions of Mozilla as well as current ones.

Somebody should patch calendar-views.css, though.

Comment 13

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Ah, looks like it was done in bug 458404.

Comment 14

[Eric Shepherd [:sheppy]]

Does this mean that -moz-pre-wrap no longer works at all, or just that we don't use it internally?  It's currently documented as deprecated.

Comment 15

[Dão Gottwald [:dao]]

(In reply to comment #14)
> Does this mean that -moz-pre-wrap no longer works at all

Yep. People can still use it in order to support gecko 1.8.*, but for 1.9.1 they need to add pre-wrap, if it's not already there -- which it should, for other browsers.

Comment 16

[Eric Shepherd [:sheppy]]

Docs have removed this from the list of supported values now, although notes are in place suggesting including it when using pre-wrap for backward compatibility purposes.