433551 - Accesskey for updater menuitem in Help menu isn't set properly for its various labels

Status: VERIFIED FIXED

(SeaMonkey :: General, defect)

Description

[Vlado Valastiak [:wladow]]

Attachment: screenshot

Check for updates menuitem has several different labels depending on update process state. Each label has its own accesskey, but only initial accesskey is used. Fix follows.

Comment 1

[Vlado Valastiak [:wladow]]

Attachment: v1

Comment 2

[Robert Kaiser]

Thanks wladow? As we probably ported this code from FF, could you take a look if the same error is in their code as well and if so, file a bug?

Comment 3

[Vlado Valastiak [:wladow]]

They don't use separate accesskey for each label, but I do plan file bug on it and implement this. This is definetely better approach. 

Comment 4

[Robert Kaiser]

Thanks a lot!
I'm proud of SeaMonkey (or actually you looking at our product) spotting and first fixing this, but in the end, we should still care for our small brother Firefox being fixed as well - we are porting enough good stuff the other way as well.
Given that FF is in 3.0rc stage already, it might be a good idea to file the bug already now so they can possibly get it for 3.0 final.

Comment 5

[Vlado Valastiak [:wladow]]

They can't get it for 3.0, because it's string frozen. Firefox uses single accesskey for all updater labels, so when implementing this, we will have to add new accesskeys into locale file. This will be possible only for Firefox.next I suppose.

Comment 6

[[e-mail]]

Comment on attachment 320759 [details] [diff] [review]
v1

Is the problem just that the accessKey property has been mistyped in lower case?

Comment 7

[Vlado Valastiak [:wladow]]

Attachment: v2

Obviously yes, here is updated fix

Comment 8

[[e-mail]]

Comment on attachment 320884 [details] [diff] [review]
v2

Thanks.

Comment 9

[Robert Kaiser]

Heh, ok, thanks. So we already have the accesskey definitions but a typo in the code, and FF is still lacking the definitions as well. Good to know that  :)

Comment 10

[Andrew Schultz]

patch checked into CVS

Comment 11

[Vlado Valastiak [:wladow]]

Verified with Mozilla/5.0 (Windows; U; Windows NT 6.0; sk; rv:1.9pre) Gecko/2008051506 Minefield/3.0pre

Comment 12

[Vlado Valastiak [:wladow]]

ehm, with Mozilla/5.0 (Windows; U; Windows NT 6.0; sk; rv:1.9pre) Gecko/2008052302 SeaMonkey/2.0a1pre of course.