433566 - The groupbox control doesn't respect windows theme

Status: RESOLVED DUPLICATE of bug 390734

(Core :: Widget: Win32, defect)

Description

[daf]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9) Gecko/2008051206 Firefox/3.0
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9) Gecko/2008051206 Firefox/3.0

Currently Firefox 3 Strata theme doesn't make groupbox controls respect windows theme like Firefox 2 does.

Reproducible: Always

Steps to Reproduce:
1.
2.
3.

Comment 1

[daf]

Attachment: Image Showing the issue

Comment 2

[Wesley Johnston (:wesj)]

Dup of Bug 349859

Comment 4

[Kai Liu]

Not really a dupe of bug 349859 because that was about making it look native for Classic.  Because of the way that was done (using the windows-default-theme metric instead of the (unfortunately non-existent) windows-is-themed metric), that "regressed" the the appearance of the groupbox for third-party styles.

But it wasn't really a regression, as styled Windows didn't use use native styling, either: it just drew a single-width rounded box which happened to appear native for any Luna, Royale, etc. (but not Aero!), so if the reporter here happened to use a style that didn't follow the Luna look, it would have looked wrong either way.  Bug 349859 really should have been morphed to a classic-only bug and resolved, and another bug kept open for the general-case fix.

I think it's probably best to morph & resolve bug 349859, use this bug into a general bug for the native widget work that would be required to properly handle groupboxes, and set bug 390734 and bug 236107 to depend on this bug.

Comment 5

[Kai Liu]

(Unless you want to do the native widget stuff in bug 349859, but my understanding was that it was best in cases like this to resolve the old bug and use a new bug, to avoid confusion.)

Comment 6

[daf]

I never noticed that the groupbox wasn't actually following Windows Styles theme. Besides the issue here I've noticed other diferences like the top border of the tab control and the new listbox (no idea what happened there).

Is there any tracker bug for these kind of issues?

Comment 7

[Kai Liu]

(In reply to comment #6)
> Is there any tracker bug for these kind of issues?
> 

Not that I know of.  There are a number of theme issues because not everything is rendered natively; many of these issues have been around for a long time, and with each release, more and more of them get addressed.

Comment 8

[Robert Kaiser]

We really need groupboxes to go through nsITheme/-moz-appearance, IMHO.