43420 - textarea inherits align="center" from parent td

Status: VERIFIED FIXED

(Core :: Layout: Form Controls, defect, P3)

Description

[Karl Johan Kleist]

The text in the input field becomes centered.

Possible cause: The "td" element which is the parent to
the "textarea" element has the "align" attribute set to "center".

This is hardly the desired effect of this attribute, the text should
be left-aligned (as it is in Netscape 4.7 / Opera 3.62 / IE 5).

Comment 1

[Eric Pollmann]

Still looking at what might be causing this one - CC'in Mike in case he knows, 
but I'm seeing it on NT too.

Comment 2

[Eric Pollmann]

This is probably being inherited because align=center is mapped into text-align 
css attribute in MapAttributesInto for nsHTMLTableCellElement.  Somehow it looks 
like this css is getting inherited into the table.

Handing of to Mike and CC'ing Pierre in case he has some insight.

Comment 3

[Pierre Saslawsky]

Text fields should not inherit the text-align property. Their alignment should be 
reset to the default for the current direction ('ltr' or 'rtl').

Reassigned to rods.

Comment 4

[rods (gone)]

I think this is an editor issue, reassigning

Comment 5

[rubydoo123]

giving this one to Simon to see if he can help resolve the issue

Comment 6

[Simon Fraser [no longer active]]

Huh? This isn't anything to do with me.

Comment 7

[kinmoz]

Reassign to [e-mail]. This is fallout from Ender-Lite. The old 
heavy-weight text widgets had a similar problem, but [e-mail] fixed 
it.

Comment 8

[kinmoz]

Cc'ing [e-mail]

Comment 9

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Perhaps this fix should be either:
 1) quirks-mode only, or
 2) in ua.css, so the author can override it if desired

Comment 10

[rubydoo123]

SImon I gave it to you for load balancing of the bugs, but that's ok

Comment 11

[Simon Fraser [no longer active]]

beppe: my sloughing off of this bug was probably a bit premature. But now that 
ender-light is on, I don't think that there is any editor-specific code that 
deals with styling the text field contents; this should all happen within layout. 
So I think this bug needs to go back to them.

Comment 12

[Pierre Saslawsky]

I'm taking it back. I'll look into DBaron's suggestion of fixing it in ua.css. 
Note to self: check the result when editing centered static fields in Composer.

Comment 13

[Anthony Baxter]

FWIW, This also impacts Zope pretty badly - it renders
the textareas that are used heavily almost unusable.

Comment 14

[Pierre Saslawsky]

David & Ian: I propose to fix this by adding a '-moz-default' value to the 
'text-align' property in order to reset the alignement (left or right) according 
to the direction (ltr or rtl). Instead of using '-moz-default', we could also 
support 'default' and ask the WG what they think.

In html.css, the INPUT element defines 'text-align:left'. A cheap way of fixing 
the bug would have been to do the same thing for TEXTAREA elements and let the 
i18n folks deal with the problem in r-t-l systems.

Comment 15

[Pierre Saslawsky]

Attachment: proposed fix

Comment 16

[Pierre Saslawsky]

Attachment: another testcase

Comment 17

[Hixie (not reading bugmail)]

-moz-default sounds good to me, we should also suggest it for CSS3.

Comment 18

[Pierre Saslawsky]

Fix checked in:
html.css
nsCSSKeywordList.h
nsCSSProps.cpp

Comment 19

[Jeffrey Baker]

How is this different from Bug 46987?  If it isn't, this has regressed.

Comment 20

[Michael Hore]

I'm running M17 of the missing build id, but help/about gives me
Mozilla/5.0 (X11; U; Linux 2.2.16-3 i686; en-US; m17) Gecko/20000807
this wasn't checked into the m17 branch or something? I still have this problem
and yeah, bug 46987 looks awful familiar

Comment 21

[Chris Petersen]

Change QA contact to [e-mail]

Comment 22

[bsharma]

Updating QA contact.

Comment 23

[jerone]

Verified Build 2001081303 os:win95,mac8.6,winNT