434283 - superclass declaration should not use macro because source navigator cannot realize it..

Status: UNCONFIRMED

(Core :: Layout, enhancement)

Description

[Kenny YU (:kennyyu)]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8.1.14) Gecko/20080418 Ubuntu/7.10 (gutsy) Firefox/2.0.0.14 XPCOMViewer/1.0a1
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8.1.14) Gecko/20080418 Ubuntu/7.10 (gutsy) Firefox/2.0.0.14 XPCOMViewer/1.0a1

I think we can replace this macro so that Red Hat source navigator works better... I've also enclosed a patch for this. Could you have a look?


===============


Index: nsInlineFrame.h
===================================================================
RCS file: /cvsroot/mozilla/layout/generic/nsInlineFrame.h,v
retrieving revision 1.71
diff -u -8 -p -r1.71 nsInlineFrame.h
--- nsInlineFrame.h     5 Jan 2008 02:11:20 -0000       1.71
+++ nsInlineFrame.h     18 May 2008 07:59:22 -0000
@@ -71,17 +71,17 @@ class nsAnonymousBlockFrame;
 #define NS_INLINE_FRAME_BIDI_VISUAL_IS_RIGHT_MOST    0x00800000
 
 /**
  * Inline frame class.
  *
  * This class manages a list of child frames that are inline frames. Working with
  * nsLineLayout, the class will reflow and place inline frames on a line.
  */
-class nsInlineFrame : public nsInlineFrameSuper
+class nsInlineFrame : public nsHTMLContainerFrame
 {
 public:
   friend nsIFrame* NS_NewInlineFrame(nsIPresShell* aPresShell, nsStyleContext* aContext);
 
   // nsISupports overrides
   NS_IMETHOD QueryInterface(const nsIID& aIID, void** aInstancePtr);
 
   // nsIFrame overrides



====================




Reproducible: Always




I think we can replace this macro so that Red Hat source navigator works better... I've also enclosed a patch for this. Could you have a look?

Comment 1

[Kenny YU (:kennyyu)]

Attachment: change nsInlineFrameSuper to nsHTMLContainerFrame

Comment 2

[Wayne Mery (:wsmwk)]

Comment on attachment 321464 [details] [diff] [review]
change nsInlineFrameSuper to nsHTMLContainerFrame

Kenny, you need to request review per https://developer.mozilla.org/En/Developer_Guide/How_to_Submit_a_Patch