434881 - Nothing happens when "Back up bookmarks" is clicked

Status: RESOLVED FIXED

(Cloud Services :: General, defect, P1)

Description

[Ryan Steele]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-GB; rv:1.9) Gecko/2008051206 Firefox/3.0
Build Identifier: 0.1.29

I installed the plugin on my Windows XP machine with Firefox 3 RC1. I click "Tools > Weave > Sign in..." and click Next to go to step 2 of the Weave setup wizard. When I click the "Back up bookmarks" button, nothing happens. The following error shows up in the Error Console:

Error: uncaught exception: [Exception... "Component returned failure code: 0x80004005 (NS_ERROR_FAILURE) [nsIStringBundle.GetStringFromName]"  nsresult: "0x80004005 (NS_ERROR_FAILURE)"  location: "JS frame :: file:///C:/Program%20Files/Mozilla%20Firefox%203%20Beta%205/modules/utils.js :: PU_getString :: line 173"  data: no]

Reproducible: Always

Steps to Reproduce:
1.
2.
3.

Comment 1

[Dan Mills [:thunder]]

Possibly the interface for backing up bookmarks have changed.  We'll investigate.

Comment 2

[Myk Melez [:myk] [@mykmelez]]

Looking.  I suspect perhaps the properties file doesn't get loaded automatically on Windows and Linux.

Comment 3

[Myk Melez [:myk] [@mykmelez]]

Attachment: patch v1: fixes problem

There are two places.properties files, one exposed by PlacesUtils, the other by PlacesUIUtils.  The two strings being used by bookmark backup are accessible via the latter interface.  Here's a patch that grabs them from there instead.

Comment 4

[Dan Mills [:thunder]]

Comment on attachment 321995 [details] [diff] [review]
patch v1: fixes problem

Cool.  Commit away!

Comment 5

[Aleksander Adamowski]

Has it been committed? Is this fix in Weave 0.1.30? I'm asking because when installing 0.1.30, bookmarks backup didn't work too.

Comment 6

[Myk Melez [:myk] [@mykmelez]]

Yes, this was fixed in revision 896157149a3e <http://hg.mozilla.org/labs/weave/index.cgi/rev/896157149a3e> and is part of Weave 0.1.30.  Does bookmarks backup fail in the same way for you (i.e. nothing happening except for that error showing up in the error console)?

Comment 7

[Aleksander Adamowski]

I figured out that in my case, although the symptom was the same (nothing happening on backup), it was due to corrupted bookmarks interrupting the process - see bug 436696.

Comment 8

[Myk Melez [:myk] [@mykmelez]]

This bug is fixed, so resolving as such.  But as Aleksander noted, there are some related issues per bug 436696.  I'll follow up on those there.