43525 - crash when NetMotion is enabled due to 0.0.0.0 being opened.

Status: RESOLVED WORKSFORME

(Core :: Networking, defect, P3)

Description

[Michael P. Frank]

From Bugzilla Helper:
User-Agent: Mozilla/4.0 (compatible; MSIE 5.0; Windows NT; DigExt)
BuildID:    2000041805

When NetMotion is loaded and enabled Mozilla will fail because of an 
incompatability with opening the "Any" address, 0.0.0.0, with NetMotion.  
NetMotion is software which provides wireless roaming between subnets and 
session persistence.  This is done by routing packets through a server.  
Mozilla is opening 0.0.0.0 and then connecting to it via 127.0.0.1 during 
initialization.  127.0.0.1 is recognized as a loopback by NetMotion and that is 
not an issue.  Opening and listening on "Any" is,  as well as a potential 
security hole.  By changing the following code (IpAddrAny to IpAddrLoopback) we 
were able to recompile mozilla and run with NetMotion.

.\nsprpub\pr\src\io\prsocket.c

PR_IMPLEMENT(PRStatus) PR_NewTCPSocketPair(PRFileDesc *f[])
{
#ifdef XP_UNIX
    .
    .
    .
#elif defined(WINNT)
    .
    .
    .
#else /* not Unix or NT */
    /*
     * default implementation
     */
    PRFileDesc *listenSock;
    PRNetAddr selfAddr;
    PRUint16 port;

    f[0] = f[1] = NULL;
    listenSock = PR_NewTCPSocket();
    if (listenSock == NULL) {
        goto failed;
    }
    PR_InitializeNetAddr(PR_IpAddrAny, 0, &selfAddr);
    /* PR_InitializeNetAddr(PR_IpAddrLoopback, 0, &selfAddr); */
    if (PR_Bind(listenSock, &selfAddr) == PR_FAILURE) {
        goto failed;
    }
    if (PR_GetSockName(listenSock, &selfAddr) == PR_FAILURE) {
        goto failed;
    }
    port = ntohs(selfAddr.inet.port);
    if (PR_Listen(listenSock, 5) == PR_FAILURE) {
        goto failed;
    }
    f[0] = PR_NewTCPSocket();
    if (f[0] == NULL) {
        goto failed;
    }
    PR_InitializeNetAddr(PR_IpAddrLoopback, port, &selfAddr);

    /*
     * Only a thread is used to do the connect and accept.
     * I am relying on the fact that PR_Connect returns
     * successfully as soon as the connect request is put
     * into the listen queue (but before PR_Accept is called).
     * This is the behavior of the BSD socket code.  If
     * connect does not return until accept is called, we
     * will need to create another thread to call connect.
     */
    if (PR_Connect(f[0], &selfAddr, PR_INTERVAL_NO_TIMEOUT)
            == PR_FAILURE) {
        goto failed;
    }
    f[1] = PR_Accept(listenSock, NULL, PR_INTERVAL_NO_TIMEOUT);
    if (f[1] == NULL) {
        goto failed;
    }
    PR_Close(listenSock);
    return PR_SUCCESS;

failed:
    if (listenSock) {
        PR_Close(listenSock);
    }
    if (f[0]) {
        PR_Close(f[0]);
    }
    return PR_FAILURE;
#endif
}

Comment 1

[qaz2]

addign crash keyword

Comment 2

[Tomer Brisker]

This is fairly old, and you are using an ancient build... Nor does this list any
method to reproduce the bug, which in itself isn't too clear - it looks like a
proposed solution to some unclear problem... Please read the bug writing
guidelines at http://www.mozilla.org/quality/bug-writing-guidelines.htm

Comment 3

[Asa Dotzler [:asa]]

setting bug status to New

Comment 4

[Darin Fisher]

reporter: please clarify.  thanks!

Comment 5

[benc]

mass move, v2.
qa to me.

Comment 6

[Gagan]

->darin

Comment 7

[Darin Fisher]

reporter: are you still seeing this bug in recent builds?

Comment 8

[Matthias Versen [:Matti]]

no response