435460 - Do XULRunner 1.9RC2 release spin

Status: RESOLVED FIXED

(Release Engineering :: General, defect, P2)

Description

[Benjamin Smedberg]

We should do a XULRunner 1.9RC1 spin using the FF3RC1 source code, by following the instructions outlined at https://bugzilla.mozilla.org/show_bug.cgi?id=415180#c47

mfinkle, can you do this?

Comment 1

[Dave Townsend [:mossop]]

It has been decided that there will be an RC2 of Firefox 3 so I suggest that we instead do a spin of XULRunner based on the RC2 code which apparently will be code complete in the next day or so.

Comment 2

[Mark Finkle (:mfinkle) (use needinfo?)]

Attachment: bootstrap.cfg for xulrunner based in firefox rc2

bootstra.cfg we can use to generate a xulrunner build based on the firefox 3rc2 codebase.

Ben, I wasn't sure if we needed appVersion, oldAppVersion, and oldBuild. I removed prettyAUSVersion as it wasn't in the fx-moz19-bootstrap.cfg file (whic I was using as an example)

Comment 3

[Mark Finkle (:mfinkle) (use needinfo?)]

Attachment: bootstrap.cfg for staging to test this first

We can try this on staging first. I kept prettyAUSVersion in case the string was used somewhere and changed the "3.0" stuff to "1.9" since xulrunner is the platform, not firefox.

Comment 4

[[e-mail] (:bhearsum)]

Comment on attachment 322930 [details] [diff] [review]
bootstrap.cfg for staging to test this first

>Index: tools/release/configs/xr-moz19-staging-bootstrap.cfg
>===================================================================
> # oldVersion and oldRc refer to the previous release
>-oldVersion      = 3.0b2
>+oldVersion      = 1.9b4

Is 1.9b4 the last time there was a Xulrunner release? It shouldn't matter, since AFAICT this is only used for updates, l10n, and automatic staging.

This is fine to land, afaict. For some reason I thought that we popped nightlies/dep builds out with Buildbot, which isn't the case. This is even easier than I originally thought, hooray! I'd still like to test this on staging first because of the version change, but I expect no problems.

(ref: https://bugzilla.mozilla.org/show_bug.cgi?id=415180#c47)

mfinkle: you can go ahead and push the buttons here when you land: http://staging-1.9-master.build.mozilla.org:8810/waterfall

Builds should show up here: http://fx-linux-1.9-slave1.build.mozilla.org/pub/mozilla.org/xulrunner/nightly/

Comment 5

[[e-mail] (:bhearsum)]

Forgot to mention:
We should wait until the Fx 3.0rc2 build is idle/done before doing it for realz.

Comment 6

[Mark Finkle (:mfinkle) (use needinfo?)]

Attachment: bootstrap.cfg for production

Ok, this is the cfg for production

Comment 7

[[e-mail] (:bhearsum)]

Comment on attachment 322942 [details] [diff] [review]
bootstrap.cfg for production

Looks fine. You should be able to land this whenever you want - don't kick the builds right away though.

Comment 8

[Nick Thomas [:nthomas] (UTC+12)]

Attachment: [checked in] Enable symbol generation and upload for win32 release buidls

Comment 9

[Mark Finkle (:mfinkle) (use needinfo?)]

Checking in tools/release/configs/xr-moz19-bootstrap.cfg;
/cvsroot/mozilla/tools/release/configs/xr-moz19-bootstrap.cfg,v  <--  xr-moz19-bootstrap.cfg
new revision: 1.5; previous revision: 1.4
done

And:

cvs tag -F RELEASE_AUTOMATION_M9_1 tools/release/configs/xr-moz19-bootstrap.cfg
T tools/release/configs/xr-moz19-bootstrap.cfg

Comment 10

[Nick Thomas [:nthomas] (UTC+12)]

Comment on attachment 322953 [details] [diff] [review]
[checked in] Enable symbol generation and upload for win32 release buidls

Checking in xulrunner/win32/tinder-config.pl;
/cvsroot/mozilla/tools/tinderbox-configs/xulrunner/win32/tinder-config.pl,v  <--  tinder-config.pl
new revision: 1.11.2.4; previous revision: 1.11.2.3
done

Also carried over r=ted in bug 391718 to add source server support.

Comment 11

[Dave Townsend [:mossop]]

Probably doesn't matter but should prettyAUSString be XULRunner 1.9?

Comment 12

[Nick Thomas [:nthomas] (UTC+12)]

prettyAusVersion actually went away in bug 420947 so it can be removed from the configs. There's a bunch of stuff in the bootstrap configs that these XULrunner builds never use, as we're only doing the equivalent on an en-US build.

Comment 13

[Nick Thomas [:nthomas] (UTC+12)]

Attachment: [checked in] Enable building SDK and put files in the right places

Two parts to this guy
* enable building the SDK like we do with nightly builds (all platforms)
* make the release builds go into the right place (mac and windows). We got a xulrunner/nightly/latest-xulrunner1.9rc2/ directory from the run yesterday, now removed.

Comment 14

[Mark Finkle (:mfinkle) (use needinfo?)]

Attachment: bump the buildid in the production config

apply this patch on attachment 322942 [details] [diff] [review]

Comment 15

[Nick Thomas [:nthomas] (UTC+12)]

Comment on attachment 323046 [details] [diff] [review]
[checked in] Enable building SDK and put files in the right places

Sorry, this one fell in the yawning abyss.

mozilla/tools/tinderbox-configs/xulrunner/linux/tinder-config.pl 	1.8.2.6
mozilla/tools/tinderbox-configs/xulrunner/macosx/tinder-config.pl 	1.6.2.4
mozilla/tools/tinderbox-configs/xulrunner/win32/tinder-config.pl 	1.11.2.5

Comment 16

[Dave Townsend [:mossop]]

The RC2 builds are available at http://ftp.mozilla.org/pub/mozilla.org/xulrunner/nightly/1.9rc2-candidates/build2/ is there anything else that needs to be done or should we close this bug?

Comment 17

[Benjamin Smedberg]

Well, after we've gotten feedback that they're ok (and that we're not doing a FF3RC3), we should copy them to xulrunner/releases/1.9.

Comment 18

[Mark Finkle (:mfinkle) (use needinfo?)]

Someone discovered that the windows release is missing msvcm80.dll, msvcp80.dll, msvcr80.dll, Microsoft.VC80.CRT.manifest from the archive (both runtime and SDK)

Comment 19

[Mark Finkle (:mfinkle) (use needinfo?)]

The nightly versions _do_ have the files

Comment 20

[(not currently active) Ted Mielczarek]

Do we not build XULRunner --enable-jemalloc? We probably should.

Comment 21

[Nick Thomas [:nthomas] (UTC+12)]

WIN32_REDIST is set to /d/msvs8/VC/redist/x86/Microsoft.VC80.CRT on the XULRunner nightly tinderbox, but not on the machine used to create the XULRunner builds. You can set it in the tinder-config.pl for win32 if you decide against jemalloc.

Comment 22

[Mark Finkle (:mfinkle) (use needinfo?)]

Attachment: incudes the update for RC3 and enables jemalloc

fixes the jemalloc problem and bumps everything to rc3

Comment 23

[Mark Finkle (:mfinkle) (use needinfo?)]

Attachment: same as previous with prettyAusVersion removed

Comment 24

[Nick Thomas [:nthomas] (UTC+12)]

Comment on attachment 324448 [details] [diff] [review]
same as previous with prettyAusVersion removed

>Index: tools/tinderbox-configs/xulrunner/win32/mozconfig
>===================================================================
>RCS file: /cvsroot/mozilla/tools/tinderbox-configs/xulrunner/win32/mozconfig,v
>retrieving revision 1.2
>diff -u -8 -p -r1.2 mozconfig
...
>+ac_add_options --enable-jemalloc

r+. The change above will affect nightlies, so also land this on the release branch before starting those builds off.

Comment 25

[Mark Finkle (:mfinkle) (use needinfo?)]

Attachment: patch for release branch

enables jemalloc on release branch

Comment 26

[Mark Finkle (:mfinkle) (use needinfo?)]

landed attachment 324448 [details] [diff] [review], tagged the .cfg file for release automation, and landed attachment 324453 [details] [diff] [review] for release branch

Comment 27

[Mark Finkle (:mfinkle) (use needinfo?)]

this is done