435891 - In Firefox 3 RC1 and latest XULRunner trunk builds, non-chrome motifs are broken

Status: RESOLVED FIXED

(Other Applications :: ChatZilla, defect)

Description

[worms]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.0; rv:1.9b4pre) Gecko/2008021302 Mnenhy/0.7.5.0 SeaMonkey/2.0a1pre XpcomViewer/0.9
Build Identifier: 

The current online motifs usually use the import CSS rule to import output-base.css from chrome.
e.g.:
@import url(chrome://chatzilla/content/output-base.css);

In Firefox 3 RC1 and recent XULrunner trunk builds, since changes due to:

https://bugzilla.mozilla.org/show_bug.cgi?id=292789
http://adblockplus.org/blog/web-pages-accessing-chrome-is-forbidden
http://starkravingfinkle.org/blog/2008/04/extension-developers-chrome-uri-changes-you/

online motifs cannot access chrome (and also images in chrome, like <img src="chrome://blah.png"/>, so the smileys are also broken).

The JavaScript console gives the error: 

Security Error: Content at http://www.corpsmoderne.net/~eve97/gothdns/motifs_chatzilla_online/chevron.css may not load or link to chrome://chatzilla/content/output-base.css 

when trying to use the motif located at http://www.corpsmoderne.net/~eve97/gothdns/motifs_chatzilla_online/chevron.css

Mark Finkle says that using the "contentaccessible=yes" flag in the chrome manifest should fix that.


Reproducible: Always

Steps to Reproduce:
1. Use Firefox 3 RC1 and ChatZilla 0.9.82.1 with the motif: http://www.corpsmoderne.net/~eve97/gothdns/motifs_chatzilla_online/chevron.css
2. 
3.
Actual Results:  
No smileys are showing, everything is horribly broken in the message table (nicks, underline of links, etc.)


Using a temporary workaround for the chevron motif, located at:
http://www.corpsmoderne.net/~eve97/gothdns/motifs_chatzilla_online/chevron_online.css

(I've put output-base.css and the smileys images online, and import that in the motif instead of the chrome url)

Comment 1

[James Ross]

Attachment: [checked in] Load output-base forcefully

This forcefully loads output-base.css before the motif in the output window, ensuring that the core display functionality (inc. emoticons) work.

There is a further issue, with any motif that imports one of the standard motifs (default, light, dark), which will fail. We can't solve that one anywhere near as nicely, but updating the website copies and using them should work fine.

Comment 2

[:Gijs (he/him)]

Comment on attachment 323323 [details] [diff] [review]
[checked in] Load output-base forcefully

Nice. r=me, assuming you've tested this.

Comment 3

[James Ross]

Attachment: Remove output-base @imports from shipped motifs

These are no longer needed, so might as well remove them. :)

Comment 4

[:Gijs (he/him)]

Comment on attachment 323616 [details] [diff] [review]
Remove output-base @imports from shipped motifs

r=me

Keep in mind that if we change this on the website, we're screwing over people who use the faces motif on a non-current CZ, because those import the website versions. Which would perhaps be a lame thing to do. Because the import rules don't actually *hurt* (afaict), we might as well leave them as far as the website is concerned.

Comment 5

[James Ross]

Comment on attachment 323616 [details] [diff] [review]
Remove output-base @imports from shipped motifs

Decided against doing this, as it will make keeping the website up-to-date harder, and isn't actually worth anything.