436106 - [ForumUX] Spaces in URLs are converted to plusses

Status: VERIFIED FIXED

(support.mozilla.org :: Forum, task)

Description

[Jason Barnabe (np)]

If you post a link to http://releases.mozilla.org/pub/mozilla.org/firefox/releases/2.0.0.14/win32/en-US/Firefox%20Setup%202.0.0.14.exe

it becomes a link to http://releases.mozilla.org/pub/mozilla.org/firefox/releases/2.0.0.14/win32/en-US/Firefox+Setup+2.0.0.14.exe

It should just stay the same.

Comment 1

[Paul Craciunoiu [:paulc]]

Attachment: SQL patch, v1

Removing the regex for turning " " (space) into "+" (plus) does the trick. I used the following test post:
---------------
((Test kb rename old|blah))

[http://releases.mozilla.org/pub/mozilla.org/firefox/releases/3.0.12/win32/en-US/Firefox%20Setup%203.0.12.exe|text]
---------------
Noted that internal links still work as expected.

Comment 2

[Paul Craciunoiu [:paulc]]

Also bumping the severity, since this breaks links with spaces (e.g. for links to download our releases)

Comment 3

[Paul Craciunoiu [:paulc]]

Oh. For testing, make sure to clear the cachelib (regexes are cached there, see webroot/lib/smarty_tiki/outputfilter.urlt.php)

Comment 4

[[:Cww]]

Comment on attachment 390050 [details] [diff] [review]
SQL patch, v1

tested on sumotools and it wfm.

Comment 5

[Laura Thomson :laura]

Did you test for regressions?  That is, is this bit of regex used by any other bits of code where it might actually be correct?

Comment 6

[Paul Craciunoiu [:paulc]]

I tested a bit, URLs with spaces seem to be handled alright in articles. Does it work for you Laura? Try removing the ! before $cachelib on line 95 of outputfilter.urlt.php to test.

Comment 7

[Laura Thomson :laura]

Comment on attachment 390050 [details] [diff] [review]
SQL patch, v1

Let's get it into QA.

Comment 8

[Paul Craciunoiu [:paulc]]

(In reply to comment #7)
Laura: should I file an IT bug for running the SQL and clearing the cache on ForumUX?

Comment 9

[Laura Thomson :laura]

On the staging server?  Yep.

Comment 10

[Paul Craciunoiu [:paulc]]

Cheng, Chris: want to verify this on our forumux branch?
http://sumo-forumux.stage.mozilla.com/en-US/kb/

Comment 11

[Stephen Donner [:stephend] Not actively reading bugmail]

(In reply to comment #8)
> (In reply to comment #7)
> Laura: should I file an IT bug for running the SQL and clearing the cache on
> ForumUX?

Not sure if this was filed before, but looks like we need it now, given that the URL in my test post in https://support-stage.mozilla.org/tiki-view_forum_thread.php?comments_parentId=446729&forumId=4 still gets a "+" added where %20 (space char) was.

Comment 12

[Stephen Donner [:stephend] Not actively reading bugmail]

Reopening; SQL's been run in bug 511993, and my test post in comment 11's URL still has + characters as delimiters.

Comment 13

[Laura Thomson :laura]

The SQL was run on forumux, not on support-stage.  Filed  bug 517975 to get it run there.

Comment 14

[James Socol [:jsocol, :james]]

Closing since bug 517975 closed. Stephen?

Comment 15

[Stephen Donner [:stephend] Not actively reading bugmail]

(In reply to comment #14)
> Closing since bug 517975 closed. Stephen?

Yup, w00t; verified FIXED on https://support-stage.mozilla.org/tiki-view_forum_thread.php?comments_parentId=446729&forumId=4.

Comment 16

[David Tenser [:djst]]

Not sure if this needs upstreaming?