437864 - In <pageInfo.xul>, "Warning: XUL box for hbox element contained an inline img child, forcing all its children to be wrapped in a block."

Status: RESOLVED FIXED

(Firefox :: Page Info Window, defect)

Description

[Serge Gautherie (:sgautherie)]

(Found while testing bug 392050.)

1. Load URL page.
2. Page Info > Media.
3. Select the SWF line.

[Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9pre) Gecko/2008060507 Minefield/3.0pre] (nightly) (W2Ksp4)
{{
Warning: XUL box for hbox element contained an inline img child, forcing all its children to be wrapped in a block.
Source File: chrome://browser/content/pageinfo/pageInfo.xul
Line: 0
}}

[Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9pre) Gecko/2008060802 SeaMonkey/2.0a1pre] (nightly) (W2Ksp4)
{{
Warning: XUL box for hbox element contained an inline img child, forcing all its children to be wrapped in a block.
Source File: chrome://navigator/content/pageinfo/pageInfo.xul
Line: 0
}}

Comment 1

[Philip Chee]

> Warning: XUL box for hbox element contained an inline img child, forcing all
> its children to be wrapped in a block.
> Source File: chrome://navigator/content/pageinfo/pageInfo.xul
> Line: 0

See Bug 408834

Comment 2

[Serge Gautherie (:sgautherie)]

(In reply to comment #1)
> See Bug 408834

Right ! Duplicate, obviously :->
Marking as dependent for now as a use case.

Comment 3

[Philip Chee]

> Right ! Duplicate, obviously :->
Wrong. The Page Info implementations are forked. Unfortunately we also copied the firefox bugs as well.

Comment 4

[Serge Gautherie (:sgautherie)]

http://mxr.mozilla.org/comm-central/find?string=%2Fpageinfo%2FpageInfo.css

Just copy SeaMonkey fix.

Comment 5

[Ekanan Ketunuti]

Attachment: patch

Changed img display to block.

Comment 6

[Serge Gautherie (:sgautherie)]

Comment on attachment 627839 [details] [diff] [review]
patch

>Bug 437864 - In <pageInfo.xul>, "Warning: XUL box for hbox element contained an inline img child, forcing all its children to be wrapped in a block." r=sgautherie

Don't add "r=..." before you get a r+.

Comment 7

[Ekanan Ketunuti]

Attachment: patch1

rm r=...

Comment 8

[Jared Wein [:jaws] (please needinfo? me)]

Pushed to mozilla-inbound:
https://hg.mozilla.org/integration/mozilla-inbound/rev/71125631398b

Comment 9

[Graeme McCutcheon [:graememcc]]

https://hg.mozilla.org/mozilla-central/rev/71125631398b

(Merged by Ed Morley)