Closed Bug 437959 Opened 16 years ago Closed 16 years ago

View installed add-ons

Categories

(Firefox for Android Graveyard :: General, enhancement, P2)

Product:
Firefox for Android Graveyard
Component:
General
Platform:
Other
Maemo
Type:
enhancement

Tracking

(Not tracked)

Status:
VERIFIED FIXED
Milestone:
fennec1.0m7

People

(Reporter: christian.bugzilla, Assigned: mfinkle)

References

Details

Attachments

(1 file, 1 obsolete file)

Add-on features with some simple theming
20.89 KB, patch
Gavin
: review+
Details | Diff | Splinter Review
Assignee: nobody → dtownsend
Priority: -- → P2
Target Milestone: Fennec M6 → Fennec M5
Assignee: dtownsend → cbayley
Flags: wanted-fennec1.0+
Status: NEW → ASSIGNED
Target Milestone: Fennec M5 → Fennec M6
Target Milestone: Fennec M6 → Fennec A1
Assignee: cbayley → nobody
Status: ASSIGNED → NEW
Assignee: nobody → mark.finkle
Target Milestone: Fennec A1 → Fennec M7
Blocks: 437958
Blocks: 437960
Attached patch WIP: add-on functionality (obsolete) — — Splinter Review 
Initial patch for supporting installing, viewing and removing add-ons. It uses a modified XPInstall observer to handle installing from a website. It uses the new preferences to support the "Get Addons" panel in the Add-ons Manager.

The main differences/issues are:
* We use a panel in the main browser window (uses an iframe to host the manager) so the xpinstall preferences needed to be tweaked a bit.
* "Get Addons" doesn't function yet, as AMO has no Fennec addons.
* The iframe hosted Add-ons Manager needs some theming to blend in better.
If needed, this patch could be landed as is (after a review) and the theming changes added as a followup bug.
ame as previous patch but adds some simple theming to make the iframed dialog fit better into the style of the app.
Attachment #334218 - Attachment is obsolete: true
Attachment #334310 - Flags: review?(gavin.sharp)
Attachment 334310 [details] [diff] depends on the patch in bug 444248 for toolbar interactions.
Comment on attachment 334310 [details] [diff] [review]
Add-on features with some simple theming

It pains me to see that gXPInstallObserver code duplicated :(

Seems like it would be a good candidate for turning into a module, right? Just pass in the two string bundles and notification box. New bug?
Attachment #334310 - Flags: review?(gavin.sharp) → review+
Yeah a new bug for the module. We add something to the notification callback so it will need a small refactor. I'll file a bug.

changeset:   104:28cbb8ab4a2a
tag:         tip
user:        Mark Finkle <mfinkle@mozilla.com>
date:        Tue Aug 19 22:18:36 2008 -0400
summary:     b=437959, r=gavin. View, install and remove add-ons
Status: NEW → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
verified with beta3
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: