Closed Bug 438283 Opened 16 years ago Closed 16 years ago

Move Top 10 sorting out of the bookmark classes

Categories

(Camino Graveyard :: Bookmarks, defect)

All
macOS
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
Camino2.0

People

(Reporter: stuart.morgan+bugzilla, Assigned: stuart.morgan+bugzilla)

Details

Attachments

(1 file)

Attached patch fixSplinter Review
Another tiny step toward saner bookmark code. This moves the logic for how the top-10 list is actually decided out of the base bookmark classes, and into the top-10-managing class where it belongs (and re-expresses it in terms of sort descriptors). It also fixes a bug where the list may not be calculated correctly when two bookmarks have the same URL but different visit counts.

More sort cleanup will follow, but I want to keep the pieces small.
Attachment #324407 - Flags: superreview?(mikepinkerton)
Hardware: PC → All
Comment on attachment 324407 [details] [diff] [review]
fix

sr=pink
Attachment #324407 - Flags: superreview?(mikepinkerton) → superreview+
Landed on trunk.
Status: NEW → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
Target Milestone: --- → Camino2.0
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: