438834 - fcc2 (Send Copy to menu in composition window) does not work, regression from #413781

Status: RESOLVED FIXED

(Thunderbird :: Message Compose Window, defect)

Description

[Sunil Mohan Adapa]

User-Agent:       Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.8.1.14) Gecko/20080404 Iceweasel/2.0.0.14 (Debian-2.0.0.14-0etch1)
Build Identifier: version 3.0a2pre (2008061121) [my build]

MessageFcc () in MsgComposeCommands.js fails when "Send Copy to" menu item selected.

Reproducible: Always

Steps to Reproduce:
1. Open compose window
2. Set FCC using "Send Copy to"
3. Send the message
Actual Results:  
FCC is not performed.

Expected Results:  
The sent mail is copied to the folder selected in "Send Copy to" menu.

Comment 1

[Sunil Mohan Adapa]

Attachment: Simple patch to fix the regression

Comment 2

[Magnus Melin [:mkmelin]]

In the future, please request review on your patch. Otherwise there's the risk it gets lost. See http://developer.mozilla.org/en/docs/Getting_your_patch_in_the_tree

I'll take a look at it...

Comment 3

[Magnus Melin [:mkmelin]]

Checking in mail/components/compose/content/MsgComposeCommands.js;
/cvsroot/mozilla/mail/components/compose/content/MsgComposeCommands.js,v  <--  MsgComposeCommands.js
new revision: 1.139; previous revision: 1.138
done

->FIXED

Comment 4

[Magnus Melin [:mkmelin]]

Comment on attachment 324782 [details] [diff] [review]
Simple patch to fix the regression

Thx Sunil, this looks good! r=mkmelin

Forgot to submit this first:)

Comment 5

[Sunil Mohan Adapa]

Thanks Magnus. I will ask for review in the future and set better bug parameters.