Closed Bug 439274 Opened 16 years ago Closed 16 years ago

NS_THEME_SCROLLBAR_GRIPPER_* should get its state from its parent

Categories

(Core :: Widget: Win32, defect)

Product:
Core
Component:
Widget: Win32
Version:
1.9.0 Branch
Platform:
x86
Windows Vista
Type:
defect
Priority:
Not set
Severity:
trivial

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla1.9.1a1

People

(Reporter: kliu, Assigned: kliu)

Details

(Keywords: polish)

Attachments

(2 files, 1 obsolete file)

before & after screenshot
1.08 KB, image/png
Details
w/ comment fix
1.37 KB, patch
samuel.sidler+old
: approval1.9.0.4-
Details | Diff | Splinter Review
Attached patch simple fix (obsolete) — — Splinter Review 
The scrollbar gripper state should be determined by the state of its parent, the scrollbar thumb button.
Attachment #325134 - Flags: superreview?(roc)
Attachment #325134 - Flags: review?(roc)
Flags: wanted1.9.1?
Flags: wanted1.9.0.x?
Hover and active states, before & after the patch in comment 0.
Comment on attachment 325134 [details] [diff] [review]
simple fix

the XXXdwh comment should be removed now?
Attachment #325134 - Flags: superreview?(roc)
Attachment #325134 - Flags: superreview+
Attachment #325134 - Flags: review?(roc)
Attachment #325134 - Flags: review+
Attached patch w/ comment fix — — Splinter Review 
Oops, yea, that comment can go...
Attachment #325134 - Attachment is obsolete: true
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/index.cgi/rev/36922accf51f
Status: ASSIGNED → RESOLVED
Closed: 16 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9.1
Flags: wanted1.9.1?
Attachment #325204 - Flags: approval1.9.0.1?
Attachment #325204 - Flags: approval1.9.0.1? → approval1.9.0.2?
Target Milestone: mozilla1.9.1 → mozilla1.9.1a1
Comment on attachment 325204 [details] [diff] [review]
w/ comment fix

Pushing approval out to 1.9.0.3.
Attachment #325204 - Flags: approval1.9.0.2? → approval1.9.0.3?
Doesn't really meet the "wanted" criteria (security, stability, regression from maintenance release) for 1.9.0.x. And likewise, doesn't meet the criteria for 1.9.0.4.
Flags: wanted1.9.0.x?
Attachment #325204 - Flags: approval1.9.0.4? → approval1.9.0.4-
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: