439628 - star is clipped on right side, star is not centered in column

Status: RESOLVED WORKSFORME

(Thunderbird :: Mail Window Front End, defect)

Description

[Wayne Mery (:wsmwk)]

more noticeable when message is not selected.  TB trunk.
Gary, do you see this on Mac?

Comment 1

[Gary Kwong [:gkw] [:nth10sd] (NOT official MoCo now)]

No. screenshot?

Comment 2

[Wayne Mery (:wsmwk)]

Attachment: thread pane screen shots showing thread, star, junk, attachment, read columns - vista and XP, both trunk

default theme
on vista no extensions that would affect UI and no css 

description of screen shots:

Vista
column header icons - uncentered: left justified, or left has smaller margin - note subject has bigger left margin
column contents - uncentered: all icons shifted right, some are chopped on right

XP
column header icons - uncentered: right justified, or right has smaller margin - note subject has bigger elft margin
column contents - uncentered: all are shifted right, but not as bad as on vista, none are chopped

Comment 3

[Gary Kwong [:gkw] [:nth10sd] (NOT official MoCo now)]

Attachment: screenshot of Mac TB 3.0a2pre

Not an issue here for Mac Leopard.

Comment 4

[Wayne Mery (:wsmwk)]

Attachment: screenshot of Mac TB 3.0a2pre with lines

(In reply to comment #3)
> Created an attachment (id=325798) [details]
> screenshot of Mac TB 3.0a2pre
> 
> Not an issue here for Mac Leopard.

yup not clipped, and column headers are centered.
but icons are not centered in the columns.

Comment 6

[raoul bhatia]

Attachment: screenshot

i think that this issue has been resolved now. taking a close look using 

Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9.1.2pre) Gecko/20090727 Shredder/3.0b4pre ID:20090727034746

i see that 3 px on the left and 2 px on the right side of a star. (i have the stars in the left-most column)

as soon as i select the message, the selection "rectangle"/"border" is added and i there remain 2px left and 2px right of the star.

please see the attached screenshot

Comment 7

[raoul bhatia]

taking a closer look, i see that the icons used seem to have a even pixel width.
the columns seem to have an uneven pixel count, which explains the left-by-one or right-by-one "issue".

Comment 8

[Wayne Mery (:wsmwk)]

agree, this is improved to the point of WFM as far as I am concerned.

However, certainly not centered, as is the case with most if not all columns that involve icons (like thread icon). And I think I see is more than an one px difference.

Comment 9

[Wayne Mery (:wsmwk)]

Attachment: TB star column on XP

Comment 10

[raoul bhatia]

i should have added, that i'm on windows vista.

what i am not understanding thou is, why the star in the header is smaller than the star i can select in the message pane.

Comment 11

[Bryan Clark (DevTools PM) [:clarkbw]]

wrt XP vs. Vista being different makes me think this might be related to bug 494430

Comment 12

[raoul bhatia]

reading through bug 494430, i would agree that those two bugs are related