Closed
Bug 441572
Opened 16 years ago
Closed 16 years ago
garburator: Inner classes are rewritten as if they were the outer class
Categories
(Developer Infrastructure :: Source Code Analysis, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: benjamin, Assigned: taras.mozilla)
References
()
Details
Attachments
(1 file)
435 bytes,
patch
|
benjamin
:
review+
|
Details | Diff | Splinter Review |
Testcase already committed: http://hg.mozilla.org/index.cgi/oink/rev/c9fc8a4228a9 An outer class is marked stack-only; the inner class constructor is rewritten to initialize all the *outer* class members. 1) the inner class isn't stack-only 2) even if it were, we should only initialize the inner-class members, not the outer-class members
Assignee | ||
Comment 1•16 years ago
|
||
if this weren't the last possible garburator bug, I'd suggest than in the future it'd be nicer to just attach testcase mods as a patch.
Attachment #326507 -
Flags: review?(benjamin)
Reporter | ||
Updated•16 years ago
|
Attachment #326507 -
Flags: review?(benjamin) → review+
Assignee | ||
Comment 2•16 years ago
|
||
pushed
Status: NEW → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
Updated•6 years ago
|
Product: Core → Firefox Build System
Updated•2 years ago
|
Product: Firefox Build System → Developer Infrastructure
You need to log in
before you can comment on or make changes to this bug.
Description
•