442189 - Synchronize SM and TB <msgHdrViewSMIMEOverlay.js>

Status: RESOLVED FIXED

(MailNews Core :: Security, defect)

Description

[Serge Gautherie (:sgautherie)]

(Noticed while working on bug 365723 and its duplicates.)

Comment 1

[Serge Gautherie (:sgautherie)]

Attachment: (Av1-SM) <msgHdrViewSMIMEOverlay.js> [Checkin: Comment 5]

Port
<http://bonsai.mozilla.org/cvslog.cgi?file=/mozilla/mail/extensions/smime/content/msgHdrViewSMIMEOverlay.js&rev=HEAD&mark=1.5>
{{
1.5	scott%scott-macgregor.org	2007-07-14 15:32	 	make me happy, add some removeEventListener calls to match the addEventListener calls in this file.
}}
to SeaMonkey.

Comment 2

[Serge Gautherie (:sgautherie)]

Attachment: (Bv1-SM) <msgHdrViewSMIMEOverlay.js>

Port bug 284369 and bug 380744 to SeaMonkey.
(untested)

Comment 3

[[e-mail]]

Comment on attachment 327096 [details] [diff] [review]
(Bv1-SM) <msgHdrViewSMIMEOverlay.js>

sr=me on the basis that the Thunderbird code looks like this.

Comment 4

[Serge Gautherie (:sgautherie)]

(In reply to comment #3)
> sr=me on the basis that the Thunderbird code looks like this.

Almost: code is copied, format is "fixed" where needed.

*****

Dan, Neil,

I started to port bug 134288 to TB,
but its .xul files miss the statusbars from bug 129100 (I didn't look further).
I guess TB does not want to add them ?

Yet, I was hoping to merge/unfork some/these SM+TB files,
possibly by adding some |if (gSignedStatusPanel)| in JS and some |#if SUITE| in XUL...
Does that seem wanted, or is it "better" to keep them forked ?

Comment 5

[Mark Banner (:standard8)]

Checking in mailnews/extensions/smime/resources/content/msgHdrViewSMIMEOverlay.js;
/cvsroot/mozilla/mailnews/extensions/smime/resources/content/msgHdrViewSMIMEOverlay.js,v  <--  msgHdrViewSMIMEOverlay.js
new revision: 1.14; previous revision: 1.13
done

Comment 6

[Serge Gautherie (:sgautherie)]

Comment on attachment 327068 [details] [diff] [review]
(Av1-SM) <msgHdrViewSMIMEOverlay.js>
[Checkin: Comment 5]

"approval‑seamonkey1.1.10/11=?":
Fixes leak of 4 Event Listeners.

Comment 7

[Phil Ringnalda (:philor)]

Whether or not Tb wants the statusbar icons, it *needs* them, since unlike SM it has a collapsed headerpane mode that doesn't show the signed/encrypted icon at all. Unfortunately, Tb doesn't want them to be insertbefore="offline-status", since that's "far left under the threadpane" for Tb, instead of SM's "far right, just like the headerpane icon is."

Comment 8

[Phil Ringnalda (:philor)]

And if it quells your horror at putting in that block of HTML that will then insert a string full of HTML, bug 438562 is trying to fix the string a bit, though it's blocked by the way suite's string is currently unused.

Comment 9

[[e-mail]]

(In reply to comment #7)
> Tb doesn't want them to be insertbefore="offline-status"
Perhaps we can agree on something to insertafter?

Comment 10

[Serge Gautherie (:sgautherie)]

Attachment: (Cv1-TB) <content/*>

This is the current code, as is.
I think I would need someone to send me a signed message, so I could test (the js) myself.

I tried to have a look with DOMi, but the insertion point seems not to be exactly where I "expected" it and I get exceptions...
Feel free to take over this patch ! (At least, helpwanted.)

Comment 11

[Karsten Düsterloh]

Comment on attachment 327096 [details] [diff] [review]
(Bv1-SM) <msgHdrViewSMIMEOverlay.js>

At least this got me motivated to set up my cert stuff. ;-)

Comment 12

[Mark Banner (:standard8)]

The patch doesn't apply cleanly to current trunk. Please update it:

Hunk #4 FAILED at 192.

Comment 13

[Serge Gautherie (:sgautherie)]

Attachment: (Bv1a-SM) <msgHdrViewSMIMEOverlay.js> [Checkin: Comment 15]

Bv1-SM, with comment 12 suggestion(s).

(No conflict: "your" cvs seems to have been confused by the new context (after the previous patch/checkin) :-|)

Comment 14

[Mark Banner (:standard8)]

(In reply to comment #13)
> (No conflict: "your" cvs seems to have been confused by the new context (after
> the previous patch/checkin) :-|)

Patch was confused by the changed lines around the bit it was adding. I did not know/want to investigate the consequence of the changes of the other lines on the patch to check in, therefore I flagged it.

Comment 15

[Mark Banner (:standard8)]

Checking in mailnews/extensions/smime/resources/content/msgHdrViewSMIMEOverlay.js;
/cvsroot/mozilla/mailnews/extensions/smime/resources/content/msgHdrViewSMIMEOverlay.js,v  <--  msgHdrViewSMIMEOverlay.js
new revision: 1.15; previous revision: 1.14
done

Comment 16

[Gary Kwong [:gkw] [:nth10sd] (NOT official MoCo now)]

Serge, is there anything left in this bug?

Comment 17

[Serge Gautherie (:sgautherie)]

Attachment: (Cv1a-TB) <content/*>

Cv1-TB, unbitrotted:
*see comment 10.
*commented out bundle: untested.

Comment 18

[Ludovic Hirlimann [:Usul]]

Removing myslef on all the bugs I'm cced on. Please NI me if you need something on MailNews Core bugs from me.

Comment 19

[Wayne Mery (:wsmwk)]

Closing for what has already been checked in.
If something essential is still needed here please file a new bug report.