442703 - Assigning a theme parameter overrides modules viewing permissions

Status: VERIFIED FIXED

(support.mozilla.org :: Knowledge Base Software, task)

Description

[Brian Krausz]

When you assign a theme parameter to a module that has special permissions, it overrides these permissions.

Example (what I did to discover this):
Assign Contributors module to Contributors group with parameter "theme=mozkb.css"

Comment 1

[Nelson Ko [:nkoth]]

Attachment: module filters should consistently use "AND" logic rather than "OR" logic

Good catch Brian. I think this makes sense, since if you wanted to use OR logic, you can always create multiple modules.

Comment 2

[Laura Thomson :laura]

Comment on attachment 327552 [details] [diff] [review]
module filters should consistently use "AND" logic rather than "OR" logic

I'm not really sure about the logic here (no familiarity with the module stuff)...it looks ok to me but you might want review from Jason or somebody a bit deeper in Tiki.

Comment 3

[Laura Thomson :laura]

Comment on attachment 327552 [details] [diff] [review]
module filters should consistently use "AND" logic rather than "OR" logic

Oh, and from my perspective r+.

Comment 4

[Nelson Ko [:nkoth]]

should be right - there was discussion about this in TikiWiki before and I think this is the right solution.

In r16595 (trunk) and r16596 (production).

Comment 5

[Brian Krausz]

I set the module to only appear on mozkb and it doesn't show when logged out...seems to have worked, will wait for QA to confirm.

Nelson: I only set the module to mozkb, if you want it on others just duplicate it I guess.  Thanks!!

Comment 6

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified FIXED, since both bug 441658 and bug 442267, which depended on this, are verified fixed.