44302 - Cannot exit browser after changing master password

Status: VERIFIED WORKSFORME

(Core Graveyard :: Security: UI, defect, P3)

Description

[Stephen P. Morse]

Here's a scenerio that I believe will demonstrate this bug.  However, I cannot 
currently test it out because of bug 41024 -- with a completey fresh profile I 
now hang on step 7.

1. Create a new profile and bring up the browser
2. Go to http://people.netscape.com/morse/password.htm
3. Fill in any arbitrary username and password, then submit form
4. Answer "yes" to the "do you want to save" dialog
5. Dismiss the encryption-disclaimer dialog
6. Dismiss the security-alert dialog
7. From the menu select tasks->privacy->password-manager->encrypt
8. PSM dialog for creating master password appears.  Enter password and press OK
9. Security alert appears (this is bug 44044).  Click OK
10. Security alert appears again (more bug 44044).  Click OK again.
11. Exit and reenter browser
12. From the menu select tasks->privacy->password-manager->change-password
13. Change of password dialog comes up (contrast this to bug 44291).
14. Fill in the password fields and click OK
15. Another password dialog comes up (this is bug 44299).  Dismiss it somehow.
16. Exit browser.

Browser hangs at this point.  I'd give a stack trace if I could reproduce this, 
but I currently blocked from doing so by bug 41024.

Comment 1

[Stephen P. Morse]

OK, I can get around bug 41024 (see comments in that report).

So now I have a stack trace at the time of trying to exit browser.  Not very 
informative.

USER32! 77e72c30()
nsAppShellService::Run(nsAppShellService * const 0x010e3630) line 387
main1(int 1, char * * 0x00c64bd0, nsISupports * 0x00000000) line 914 + 32 bytes
main(int 1, char * * 0x00c64bd0) line 1100 + 37 bytes
mainCRTStartup() line 338 + 17 bytes
KERNEL32! 77f1ba3c()

Also there were two assertions when I tried to do the exit.  They are:

Enabling Quirk StyleSheet
Document: Done (0.451 secs)
WEBSHELL- = 8
WEBSHELL- = 7
WEBSHELL- = 6
###!!! ASSERTION: NS_ENSURE_TRUE(docShellAsItem) failed: 'docShellAsItem', file
y:\mozilla\dom\src\base\nsGlobalWindow.cpp, line 3871
###!!! Break: at file y:\mozilla\dom\src\base\nsGlobalWindow.cpp, line 3871
###!!! ASSERTION: NS_ENSURE_TRUE(treeOwnerAsWin) failed: 'treeOwnerAsWin', file
y:\mozilla\dom\src\base\nsGlobalWindow.cpp, line 1506
###!!! Break: at file y:\mozilla\dom\src\base\nsGlobalWindow.cpp, line 1506
WEBSHELL- = 5
WEBSHELL- = 4
WEBSHELL- = 3

Comment 2

[Jay Patel [:jay]]

Putting on [nsbeta2+] radar for beta2 fix. 

Comment 3

[leger]

Per beta2 triage, moving from [nsbeta2+] to [nsbeta2-], putting on nsbeta3 
nominee radar.

Comment 4

[John Unruh]

Worksforme. This appears to be fixed.

Comment 5

[John Unruh]

Verified fixed.

Comment 6

[John Unruh]

Mass changing Security:Crypto to PSM

Comment 7

[John Unruh]

Mass changing Security:Crypto to PSM