Closed Bug 443286 Opened 16 years ago Closed 16 years ago

jsemit control flow doesn't flow as specified

Categories

(Core :: JavaScript Engine, defect)

x86
macOS
defect
Not set
normal

Tracking

()

RESOLVED FIXED

People

(Reporter: taras.mozilla, Unassigned)

References

Details

Attachments

(2 files)

http://mxr.mozilla.org/mozilla-central/source/js/src/jsemit.cpp#3055
CHECK_AND_SET_JUMP_OFFSET_AT contains a return statement as breaks the flow described at

http://mxr.mozilla.org/mozilla-central/source/js/src/jsemit.cpp#2988
Depends on: 432917
No longer depends on: 442358
Blocks: 432917
No longer depends on: 432917
TODO: dump the CFG from this function to disk to use as a benchmark
Could someone review and commit this or something similar? I can't enforce the must-flow analysis until there are no more bugs in the code.
Attached patch decmacroizationSplinter Review
Wrapped BAD_EXIT in {}
Attachment #336559 - Flags: review?(igor)
Attachment #336559 - Flags: review?(igor) → review+
pushed rev 92589edd2e3e
Status: NEW → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
Flags: in-testsuite-
Flags: in-litmus-
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: