443454 - Large number of warnings when building with ARM RVCT

Status: VERIFIED WONTFIX

(Tamarin Graveyard :: Tracing Virtual Machine, defect)

Description

[Rob Borcic]

Using the ARM RVCT 2.2 compiler to build TT for Symbian, there are several hundred warning messages. This bug will be used to track changes that reduce the warnings to a more manageable number.

Comment 1

[Steven Johnson]

The more manageable number should be exactly zero -- and once we get it there, let's convert warnings to errors so they don't crop up.

Comment 2

[Rob Borcic]

Attachment: Reduces instances of warning #830-D

Example of warning:
Warning:  #830-D: function "MMgc::GCWeakRef::operator new" has no corresponding operator delete (to be called if an exception is thrown during initialization of an allocated object)

This patch adds an empty matching delete operator for FastAllocator, GCObject, GCFinalizedObject, GCFinalizedObjectOptIn, RCObject and GCWeakRef. The extra code is only included if REQUIRE_DELETE_OPERATOR is defined and this flag is currently only defined for Symbian.

Comment 3

[Rob Borcic]

Attachment: Further reducde warnings when using RVCT 2.2.

The previous patch was included as part of changeset 492:307fb716348c.

This patch further reduces instances of warning #830-D as well as eliminating instances of Warning:  #1165-D: types cannot be declared in anonymous unions.

Comment 4

[Rob Borcic]

Attachment: Correct version of previous patch.

The previous patch was missing a change. Sorry about that.

Comment 5

[Edwin Smith]

what is the overhead of the delete operators on compilers that don't require them?  put another way what's the cost of making them not-ifdefd?

Comment 6

[Rob Borcic]

(In reply to comment #5)
It would depend on the compiler. At best, the compiler would exclude the operator and there would be no overhead. At worst, there would be a small amount of extra code and an extra function call.

Comment 7

[Steven Johnson]

pushed as changeset:   514:ecd15452554d

Comment 8

[Edwin Smith]

are there more patches coming? else lets mark FIXED