443827 - valgrind errors for editor/composer/src/crashtests/428844-1.html (due to building without --with-valgrind)

Status: RESOLVED INVALID

(Core :: DOM: Editor, defect)

Description

[Robert Sayre]

I can reliably reproduce this error. Running the composer crashtests under valgrind also reliably reproduce crashtest hanging on exit, while running other crashtest files does not reproduce the hang.

Comment 1

[Robert Sayre]

Attachment: valgrind log

To reproduce:

1) ./run-mozilla.sh /bin/bash
2) valgrind ./firefox-bin --reftest=/home/sayrer/dev/mozilla-central/editor/composer/src/crashtests/crashtests.list &> valgrind-composer.log

Comment 2

[Robert Sayre]

The errors of interest are 

==6038== Conditional jump or move depends on uninitialised value(s)
==6038==    at 0x5D1F583: nsIHTMLDocument::IsEditingOn() (nsIHTMLDocument.h:159)

and the assertions nearby.

Comment 3

[Mike Schroepfer]

Peter can you take a look since hg-blame pins those lines on you?  We've been having crashtest hangs repeatedly on linux so would be great to figure this out..

Comment 4

[Peter Van der Beken [:peterv]]

That's a bit odd, IsEditingOn returns

GetEditingState() == eDesignMode || GetEditingState() == eContentEditable

and GetEditingState returns nsHTMLDocument's mEditingState, which should be set to 0 by the nsIDocument's zeroing new() operator.

Comment 5

[Peter Van der Beken [:peterv]]

Attachment: Fix valgrind warning

This probably fixes the valgrind warnings (Robert, can you confirm that?), but it shouldn't make any difference for the hang unless our zeroing operator new isn't working. The assertions are a problem and we should fix them at some point, but they shouldn't cause hangs either.

Comment 6

[Mats Palmgren (inactive)]

I can reproduce the valgrind error using a stock jemalloc-enabled build.
In a build with "ac_add_options --with-valgrind" I don't get the error,
so I think this is a bogus error from valgrind, see bug 424040 comment 10.

Comment 7

[Mats Palmgren (inactive)]

(In reply to comment #5)
> This probably fixes the valgrind warnings 

It doesn't help.  I think --with-valgrind is required for reliable valgrind
results on jemalloc builds.

Comment 8

[Peter Van der Beken [:peterv]]

(In reply to comment #7)
> It doesn't help.  I think --with-valgrind is required for reliable valgrind
> results on jemalloc builds.

Robert, did you set that option? If not could you rerun with it set?

I'm going to be away till Wednesday next week, so if this is urgent you should look for a better owner.

Comment 9

[Robert Sayre]

yep, that's it. sorry.

Comment 10

[Jesse Ruderman]

I'm confused.  Is peterv's patch in comment 5 bogus?

This crashtest is causing crashes for me, btw.

Comment 11

[Peter Van der Beken [:peterv]]

Jesse: it shouldn't make a difference. AFAIK Robert was building without the required --with-valgrind. I think it'd be better to file a new bug on the crash.