Closed
Bug 444665
Opened 16 years ago
Closed 16 years ago
Hookup geolocation prompt to fennec's notification prompt.
Categories
(Firefox for Android Graveyard :: General, defect)
Tracking
(Not tracked)
VERIFIED
FIXED
fennec1.0m5
People
(Reporter: dougt, Assigned: dougt)
References
Details
Attachments
(1 file)
2.96 KB,
patch
|
mfinkle
:
review+
|
Details | Diff | Splinter Review |
No description provided.
Assignee | ||
Comment 1•16 years ago
|
||
Comment on attachment 328984 [details] [diff] [review] patch v.1 basically the same thing as FF.
Attachment #328984 -
Flags: review?(mark.finkle)
Comment 2•16 years ago
|
||
Comment on attachment 328984 [details] [diff] [review] patch v.1 >diff --git a/chrome/content/browser.js b/chrome/content/browser.js >+ >+ setupGeolocationPrompt: function() >+ { >+ var geolocationService = Cc["@mozilla.org/geolocation/service;1"].getService(Ci.nsIGeolocationService); >+ >+ geolocationService.prompt = function(request) { >+ >+ var notificationBox = gBrowser.getNotificationBox(); var notificationBox = Browser.getNotificationBox(); We don't have a gBrowser (and might not have one) so use "Browser" as shown. >+ var message = bundle_browser.getFormattedString("geolocation.requestMessage", [request.requestingURI.spec]); >+ notificationBox.appendNotification(message, >+ "geolocation", >+ "chrome://browser/skin/Info.png", This image does not exist in Fennec. We should get Madhava to make an image that fits the Fennec theme. Until then, just pass null. r+ with those tweaks.
Attachment #328984 -
Flags: review?(mark.finkle) → review+
Assignee | ||
Comment 3•16 years ago
|
||
changeset: 66:0c6c257bd42c tag: tip user: dougt@dougt-ubuntu date: Wed Jul 16 17:07:43 2008 -0700 summary: Geolocation UI. Bug 444665. r=mfinkle
Status: NEW → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
Comment 4•15 years ago
|
||
verified FIXED (using share, more info and don't share) on builds: Mozilla/5.0 (X11; U; Linux armv6l; en-US; rv:1.9.3a1pre) Gecko/20090821 Fennec/1.0b3pre and Mozilla/5.0 (Macintosh; U; Intel Mac OSX 10.5; en-US; rv:1.9.2a2pre) Gecko/20090808 Fennec/1.0b3pre
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•