444880 - JS component loader needs to use the JS context stack

Status: RESOLVED FIXED

(Core :: XPConnect, defect)

Description

[Ben Turner (not reading bugmail, use the needinfo flag!)]

Attachment: Patch, v1

JS component loader needs to use the JS context stack. Currently it makes a new request and doesn't suspend any that are on the stack which causes deadlock. Patch attached.

Comment 1

[Johnny Stenback (:jst)]

Comment on attachment 329196 [details] [diff] [review]
Patch, v1

- In JSCLContextHelper::~JSCLContextHelper():

+
+    JSContext* dummy;
+    mContextStack->Pop(&dummy);

It's "ok" to pass null to Pop() here, so no need for the dummy variable.

r+sr=jst

Comment 2

[Ben Turner (not reading bugmail, use the needinfo flag!)]

Attachment: Patch, v1.1

Removed the dummy var.

Comment 3

[Johnny Stenback (:jst)]

Fix checked in.

Comment 4

[Todd Whiteman]

This change is now causing a crash when the JS component loader is called from a non-JS thread. Full details posted at:
https://bugzilla.mozilla.org/show_bug.cgi?id=419192#c31

Can a check be done, and create a new request (like was being done before this patch) in the situation when there is no existing JS context stack (or whatever the problem is - no js stack for the current thread)?