Closed
Bug 445010
Opened 16 years ago
Closed 16 years ago
Migrate MailNews Junk Mail to the new prefwindow
Categories
(SeaMonkey :: Preferences, defect)
SeaMonkey
Preferences
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: iannbugzilla, Assigned: iannbugzilla)
References
Details
Attachments
(1 file)
11.33 KB,
patch
|
neil
:
review+
neil
:
superreview+
|
Details | Diff | Splinter Review |
Assignee: nobody → iann_bugzilla
Status: NEW → ASSIGNED
Attachment #329352 -
Flags: superreview?(neil)
Attachment #329352 -
Flags: review?(mnyromyr)
Comment 2•16 years ago
|
||
Comment on attachment 329352 [details] [diff] [review] pref-junk patch v0.1 (Checkin: Comment 4) > function Startup() > { >+ UpdateDependentElement("manualMark", "manualMarkMode"); >+ UpdateDependentElement("enableJunkLogging", "openJunkLog"); > } > >+function UpdateDependentElement(aBaseId, aDependentId) > { >+ var pref = document.getElementById(aBaseId).getAttribute("preference"); >+ EnableElementById(aDependentId, document.getElementById(pref).value, false); > } Since you know the preference attribute for both the manualMark and enableJunkLogging elements, you could pass in the pref id directly. You could even call EnableElementById directly i.e. EnableElementById("manualMarkMode", document.getElementById("mail.spam.manualMark").value, false); but I guess that's a little unwieldy.
Attachment #329352 -
Flags: superreview?(neil) → superreview+
Comment 3•16 years ago
|
||
Comment on attachment 329352 [details] [diff] [review] pref-junk patch v0.1 (Checkin: Comment 4) Stealing Mnyromyr's review (with his permission).
Attachment #329352 -
Flags: review?(mnyromyr) → review+
Comment on attachment 329352 [details] [diff] [review] pref-junk patch v0.1 (Checkin: Comment 4) http://hg.mozilla.org/comm-central/index.cgi/rev/647ef8ec4896
Attachment #329352 -
Attachment description: pref-junk patch v0.1 → pref-junk patch v0.1 (Checkin: Comment 4)
Status: ASSIGNED → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•